391622 - nsIWinAccessNode doesn't work, QI always fails

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

Trying to QueryInterface to nsIWinAccessNode fails.

Comment 1

[Aaron Leventhal]

Attachment: Call up to correct QI

Comment 2

[Aaron Leventhal]

Drivers: extremely low risk. Must fix.

Comment 3

[alexander :surkov (:asurkov)]

Comment on attachment 276067 [details] [diff] [review]
Call up to correct QI

>Index: accessible/src/base/nsAccessible.cpp
>===================================================================
>RCS file: /cvsroot/mozilla/accessible/src/base/nsAccessible.cpp,v
>retrieving revision 1.294
>diff -p -u -5 -r1.294 nsAccessible.cpp
>--- accessible/src/base/nsAccessible.cpp	8 Aug 2007 13:46:38 -0000	1.294
>+++ accessible/src/base/nsAccessible.cpp	10 Aug 2007 02:22:39 -0000
>@@ -242,11 +242,11 @@ nsresult nsAccessible::QueryInterface(RE
>       return NS_OK;
>     }
>     return NS_ERROR_NO_INTERFACE;
>   }
> 
>-  return nsAccessNode::QueryInterface(aIID, aInstancePtr);
>+  return nsAccessNodeWrap::QueryInterface(aIID, aInstancePtr);
> }

I don't get why you try to call wrap method because wrap class doesn't define nsISupports::QueryInterface().

> 
> nsAccessible::nsAccessible(nsIDOMNode* aNode, nsIWeakReference* aShell): nsAccessNodeWrap(aNode, aShell), 
>   mParent(nsnull), mFirstChild(nsnull), mNextSibling(nsnull), mRoleMapEntry(nsnull),
>   mAccChildCount(eChildCountUninitialized)

Comment 4

[Aaron Leventhal]

Yes it does right here:
http://lxr.mozilla.org/seamonkey/source/accessible/src/msaa/nsAccessNodeWrap.cpp#99

Comment 5

[alexander :surkov (:asurkov)]

Comment on attachment 276067 [details] [diff] [review]
Call up to correct QI

you're right, r=me