nsIWinAccessNode doesn't work, QI always fails

RESOLVED FIXED

Status

()

RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: aaronlev, Assigned: aaronlev)

Tracking

(Blocks: 1 bug, {access})

Trunk
access
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
Trying to QueryInterface to nsIWinAccessNode fails.
(Assignee)

Comment 1

11 years ago
Created attachment 276067 [details] [diff] [review]
Call up to correct QI
Attachment #276067 - Flags: review?(surkov.alexander)
(Assignee)

Updated

11 years ago
Attachment #276067 - Flags: approval1.9?
(Assignee)

Comment 2

11 years ago
Drivers: extremely low risk. Must fix.
Comment on attachment 276067 [details] [diff] [review]
Call up to correct QI

>Index: accessible/src/base/nsAccessible.cpp
>===================================================================
>RCS file: /cvsroot/mozilla/accessible/src/base/nsAccessible.cpp,v
>retrieving revision 1.294
>diff -p -u -5 -r1.294 nsAccessible.cpp
>--- accessible/src/base/nsAccessible.cpp	8 Aug 2007 13:46:38 -0000	1.294
>+++ accessible/src/base/nsAccessible.cpp	10 Aug 2007 02:22:39 -0000
>@@ -242,11 +242,11 @@ nsresult nsAccessible::QueryInterface(RE
>       return NS_OK;
>     }
>     return NS_ERROR_NO_INTERFACE;
>   }
> 
>-  return nsAccessNode::QueryInterface(aIID, aInstancePtr);
>+  return nsAccessNodeWrap::QueryInterface(aIID, aInstancePtr);
> }

I don't get why you try to call wrap method because wrap class doesn't define nsISupports::QueryInterface().

> 
> nsAccessible::nsAccessible(nsIDOMNode* aNode, nsIWeakReference* aShell): nsAccessNodeWrap(aNode, aShell), 
>   mParent(nsnull), mFirstChild(nsnull), mNextSibling(nsnull), mRoleMapEntry(nsnull),
>   mAccChildCount(eChildCountUninitialized)
(Assignee)

Comment 4

11 years ago
Yes it does right here:
http://lxr.mozilla.org/seamonkey/source/accessible/src/msaa/nsAccessNodeWrap.cpp#99
Comment on attachment 276067 [details] [diff] [review]
Call up to correct QI

you're right, r=me
Attachment #276067 - Flags: review?(surkov.alexander) → review+

Updated

11 years ago
Attachment #276067 - Flags: approval1.9? → approval1.9+
(Assignee)

Updated

11 years ago
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.