Created attachment 276091 [details] [diff] [review] Patch to replace GetAlphaBytesPerRow with GetFormat GetAlphaBytesPerRow doesn't make sense in the Cairo based image handling, and imgContainer only uses it to test for transparancy. Better is to check the format for that.
Don't you need to check for BGR too?
Created attachment 277500 [details] [diff] [review] V2: also check for BGR
Don't you need approval1.9 before you need checkin-needed?
This patch is needed to fix bug 367281, to get rid of the ugly GetAlphaBytesPerRow from gfxImageFrame. GetAlphaBytesPerRow doesn't work as expected in the Cairo based Gecko 1.9, and it would be wrong to keep this method exposed in the official Gecko 1.9 release.
Checking in modules/libpr0n/src/imgContainer.cpp; /cvsroot/mozilla/modules/libpr0n/src/imgContainer.cpp,v <-- imgContainer.cpp new revision: 1.52; previous revision: 1.51 done
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M9
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.