Remove GetAlphaBytesPerRow from imgContainer.cpp

VERIFIED FIXED in mozilla1.9beta1

Status

()

Core
ImageLib
--
trivial
VERIFIED FIXED
11 years ago
10 years ago

People

(Reporter: Alfred Kayser, Assigned: Alfred Kayser)

Tracking

unspecified
mozilla1.9beta1
Points:
---
Bug Flags:
blocking1.9 -

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

11 years ago
Created attachment 276091 [details] [diff] [review]
Patch to replace GetAlphaBytesPerRow with GetFormat

GetAlphaBytesPerRow doesn't make sense in the Cairo based image handling, and imgContainer only uses it to test for transparancy. Better is to check the format for that.
Attachment #276091 - Flags: superreview?(tor)
Attachment #276091 - Flags: review?(pavlov)

Updated

11 years ago
Attachment #276091 - Flags: review?(pavlov) → review+

Comment 1

11 years ago
Don't you need to check for BGR too?
(Assignee)

Comment 2

11 years ago
Created attachment 277500 [details] [diff] [review]
V2: also check for BGR
Attachment #276091 - Attachment is obsolete: true
Attachment #277500 - Flags: superreview?(tor)
Attachment #277500 - Flags: approval1.9?
Attachment #276091 - Flags: superreview?(tor)

Updated

11 years ago
Attachment #277500 - Flags: superreview?(tor) → superreview+
(Assignee)

Updated

11 years ago
Keywords: checkin-needed
Don't you need approval1.9 before you need checkin-needed?
Keywords: checkin-needed
(Assignee)

Comment 4

10 years ago
This patch is needed to fix bug 367281, to get rid of the ugly
GetAlphaBytesPerRow from gfxImageFrame. GetAlphaBytesPerRow doesn't
work as expected in the Cairo based Gecko 1.9, and it
would be wrong to keep this method exposed in the official Gecko 1.9 release.
Flags: blocking1.9?

Updated

10 years ago
Attachment #277500 - Flags: approval1.9? → approval1.9+

Updated

10 years ago
Flags: blocking1.9? → blocking1.9-
(Assignee)

Updated

10 years ago
Keywords: checkin-needed
Checking in modules/libpr0n/src/imgContainer.cpp;
/cvsroot/mozilla/modules/libpr0n/src/imgContainer.cpp,v  <--  imgContainer.cpp
new revision: 1.52; previous revision: 1.51
done
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M9
(Assignee)

Comment 6

10 years ago
Thanks!
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.