Closed Bug 391643 Opened 15 years ago Closed 15 years ago

Remove GetAlphaBytesPerRow from imgContainer.cpp

Categories

(Core :: ImageLib, defect)

defect
Not set
trivial

Tracking

()

VERIFIED FIXED
mozilla1.9beta1

People

(Reporter: alfredkayser, Assigned: alfredkayser)

References

()

Details

Attachments

(1 file, 1 obsolete file)

GetAlphaBytesPerRow doesn't make sense in the Cairo based image handling, and imgContainer only uses it to test for transparancy. Better is to check the format for that.
Attachment #276091 - Flags: superreview?(tor)
Attachment #276091 - Flags: review?(pavlov)
Attachment #276091 - Flags: review?(pavlov) → review+
Don't you need to check for BGR too?
Attachment #276091 - Attachment is obsolete: true
Attachment #277500 - Flags: superreview?(tor)
Attachment #277500 - Flags: approval1.9?
Attachment #276091 - Flags: superreview?(tor)
Attachment #277500 - Flags: superreview?(tor) → superreview+
Keywords: checkin-needed
Don't you need approval1.9 before you need checkin-needed?
Keywords: checkin-needed
This patch is needed to fix bug 367281, to get rid of the ugly
GetAlphaBytesPerRow from gfxImageFrame. GetAlphaBytesPerRow doesn't
work as expected in the Cairo based Gecko 1.9, and it
would be wrong to keep this method exposed in the official Gecko 1.9 release.
Flags: blocking1.9?
Attachment #277500 - Flags: approval1.9? → approval1.9+
Flags: blocking1.9? → blocking1.9-
Keywords: checkin-needed
Checking in modules/libpr0n/src/imgContainer.cpp;
/cvsroot/mozilla/modules/libpr0n/src/imgContainer.cpp,v  <--  imgContainer.cpp
new revision: 1.52; previous revision: 1.51
done
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M9
Thanks!
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.