Widen the 'Get Mail' button

RESOLVED WONTFIX

Status

Thunderbird
Mail Window Front End
--
enhancement
RESOLVED WONTFIX
11 years ago
5 years ago

People

(Reporter: Jeremy Morton, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 3 obsolete attachments)

(Reporter)

Description

11 years ago
It's a commonly used button; I'm used to the Outlook Express 'send/receive' button (rather similar functionality) being quite a bit wider; I don't think it would hurt that much to add some padding to the sides of 'Get Mail'.
(Reporter)

Comment 1

11 years ago
Created attachment 276103 [details] [diff] [review]
Patch v0.1

This patch'll do the trick, although there might be a more 'correct' way of applying this CSS.
(Reporter)

Updated

11 years ago
Attachment #276103 - Flags: review?(mscott)
Attachment #276103 - Flags: review?(bienvenu)

Comment 2

11 years ago
Comment on attachment 276103 [details] [diff] [review]
Patch v0.1

>+.toolbarbutton-1#button-getmsg toolbarbutton {
>+  padding-left:20px !important;
>+  padding-right:20px !important;
>+}

As discussed on IRC, this should be:

#button-getmsg > toolbarbutton {
  padding-left: 20px !important;
  padding-right: 20px !important;
}

And maybe you should try to find out why the !important seems to be needed.
Attachment #276103 - Flags: review?(mscott)
Attachment #276103 - Flags: review?(bienvenu)
Attachment #276103 - Flags: review-
(Reporter)

Comment 3

11 years ago
Created attachment 276104 [details] [diff] [review]
Patch v0.2

Patch v0.2 - addressed some issues raised in #developers.
Attachment #276103 - Attachment is obsolete: true
(Reporter)

Comment 4

11 years ago
Created attachment 276105 [details] [diff] [review]
Patch v0.3

Added some spaces
Attachment #276104 - Attachment is obsolete: true
(Reporter)

Updated

11 years ago
Attachment #276105 - Flags: review?(dao)
(Reporter)

Updated

11 years ago
Attachment #276105 - Flags: review?(dao) → review?(bienvenu)

Comment 5

11 years ago
Why not do the same as Microsoft and display some text instead of just empty space? A general solution would be bug 258607, a specific one:

> #button-getmsg {
>   -moz-box-orient: horizontal !important;
> }
> #button-getmsg > label {
>   display: -moz-box;
>   margin: 0px 2px;
>   -moz-margin-start: 5px;
> }
(Reporter)

Comment 6

11 years ago
(In reply to comment #5)
> Why not do the same as Microsoft and display some text instead of just empty
> space?

Because the OE button says 'Send and Receive', which TB doesn't (currently) do; it just receives, and TB calls that 'get' which is even shorter.  :-)

> A general solution would be bug 258607, a specific one:

That's a different kettle of fish; it's putting text to the right of the icon, which you have to do for all buttons or none, or one button's height will be less than the others.  I like the buttons with the text at the bottom.

Comment 7

11 years ago
(In reply to comment #6)
So you want this to happen only when the button text is already displayed beneath it? Then please adapt the patch to do only that. (I had assumed that the icon-only button was too narrow.)

I'm not sure whether padding a single button will be as much easier to use as it will look more out of place, though. Would you mind attaching screenshots of how it will look like without and with your patch?
(Reporter)

Comment 8

11 years ago
Created attachment 276117 [details]
Preview screenshot

(In reply to comment #7)
> (In reply to comment #6)
> So you want this to happen only when the button text is already displayed
> beneath it? Then please adapt the patch to do only that. (I had assumed that
> the icon-only button was too narrow.)

Actually, I quite like it in any of the 3 modes.  I'm attaching a screenshot.

Comment 9

11 years ago
Comment on attachment 276105 [details] [diff] [review]
Patch v0.3

That would be up to Scott, but since our toolbar is pretty full, I don't think we want to make this button wider.
Attachment #276105 - Flags: review?(bienvenu) → review?(mscott)
(Reporter)

Comment 10

11 years ago
David:

On 1024x768 (the most common) resolution, I have acres of space in the toolbar by default.

Comment 11

11 years ago
We try to work on 800x600 (or something like that, iirc) and at the lower resolution, the toolbar was full...but anyway, Scott's the lucky one who deals with these things.
(Reporter)

Comment 12

11 years ago
Even at that low resolution, this doesn't cause the toolbar to overflow.
(Reporter)

Comment 13

11 years ago
Created attachment 276132 [details] [diff] [review]
Patch v0.4

Just occured to me that a more sensible way of doing this would be to use min-width.
Attachment #276105 - Attachment is obsolete: true
Attachment #276132 - Flags: review?(mscott)
Attachment #276105 - Flags: review?(mscott)
(In reply to comment #13)
> Created an attachment (id=276132) [details]
> Patch v0.4
> 
> Just occured to me that a more sensible way of doing this would be to use
> min-width.

You should to take care of the small icons mode then.
(Reporter)

Comment 15

11 years ago
Huh?  I don't mind the same min-width being used for all icon modes.
UI issue, CC'ing Bryan for his thoughts.
(In reply to comment #0)
> It's a commonly used button; I'm used to the Outlook Express 'send/receive'

Is it? For me, Write, Reply, and Reply All are all each more commonly used than Get Mail, and I have no reason to suspect otherwise for the other people I know irl who use thunderbird. Should we widen those buttons too? Get Mail may be popular with some users, but I'm not convinced that it's a good generalization for default ui when 10-minute polling is enabled by default.

Comment 18

10 years ago
Comment on attachment 276132 [details] [diff] [review]
Patch v0.4

Jeremy you'll want a new reviewer - mscott no longer actively reviewing, so canceling review as part of Patch Love
https://wiki.mozilla.org/Thunderbird:PatchLove

Flagging bryan on UI review
Attachment #276132 - Flags: review?(mscott) → ui-review?(clarkbw)
This is somewhat inline with the new toolbar ( bug 452281 ) however I think we need to work on a better button look instead of just widening the button.
Comment on attachment 276132 [details] [diff] [review]
Patch v0.4

I'm going to minus this.  I think it could be a good idea for the existing toolbar, however it doesn't fit in with the new toolbar style.
Attachment #276132 - Flags: ui-review?(clarkbw) → ui-review-

Comment 21

5 years ago
Jeremy, do you want to work up a new patch?
Flags: needinfo?(bugzilla)
If this is needed at all, I'd probably limit extra margins to icon-only toolbar style. I'd hate to see buttons with labels be even bigger than their label requires.

For those whose toolbar style shows labels, bug 217941 might also widen the click target for this particular button.

Otherwise this might better be done in themes/addons, not sure if this should be forced on everyone.
I do not believe this bug is necessary anymore. Bug 861867 added new icons, and the "Get Mail" button is quite a bit larger now. However, asking Richard for verification.
Flags: needinfo?(richard.marti)
I don't really see why we should widen this button. I think it is prominent enough placed at the first position on the toolbar. With the actual toolbar-button styling without a button shape in normal mode it would also look as it has unneeded gaps beside the button.

I'm closing this bug with WONTFIX as this bug was almost 5 years idle and without any demand of other persons to implement this.

Feel free to reopen this bug if you think you have a good reason why this bug should be implemented.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: needinfo?(richard.marti)
Resolution: --- → WONTFIX
Thanks. +1
Flags: needinfo?(bugzilla)
You need to log in before you can comment on or make changes to this bug.