391701 - Cleanup UI code for deleting messages

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, enhancement)

Description

[Bruno 'Aqualon' Escherl]

During work for bug 49323, I found a few possibilities to clean up the code. This bug is for doing that work.

Comment 1

[Bruno 'Aqualon' Escherl]

Attachment: WIP patch

WIP Patch needs the change from attachment 276131 [details] [diff] [review].

Comment 2

[Bruno 'Aqualon' Escherl]

Attachment: Cleanup UI code and fix shift-delete behaviour for selected folders

Note: patch still needs the attachment from bug 49323 like stated in my previous comment.

What is done by this patch:

- Fix shift-delete behaviour to delete the message folder, when there's one focused and not the selected message in that folder (see bug 49323 comment 20).
- Change unused function MsgDeleteMessage(reallyDelete, fromToolbar) to MsgDeleteMessage(reallyDelete).
- Call MsgDeleteMessage(reallyDelete) in the DefaultController instead of executing the code directly there.
- Remove function MsgDeleteMessageFromMessageWindow(reallyDelete, fromToolbar) from messageWindow.js since MsgDeleteMessage(reallyDelete) does the same thing already.
- Fix some indentation glitches.

Comment 3

[Karsten Düsterloh]

Comment on attachment 276366 [details] [diff] [review]
Cleanup UI code and fix shift-delete behaviour for selected folders

Landed on trunk.