Closed Bug 391763 Opened 15 years ago Closed 15 years ago

Tree column splitters are really difficult to use

Categories

(Core :: XUL, defect)

defect
Not set
major

Tracking

()

RESOLVED FIXED

People

(Reporter: neil, Assigned: neil)

References

()

Details

(Keywords: regression)

Attachments

(1 file)

Since the units changes, it can be quite difficult to hover at just the right place to trigger a tree column splitter. Depending on your DPI you used to have about eight pixels to aim at but since the units changes you may only have one.
Attached patch Proposed patchSplinter Review
Note: By comparison with my branch build, the hit test area appears to be 4 pixels from the right and the left edge and the next 3 pixels. I've thus changed the right check to be <= to allow it to include the 4th pixel.
Assignee: Jan.Varga → neil
Status: NEW → ASSIGNED
Attachment #276201 - Flags: superreview?(roc)
Attachment #276201 - Flags: review?(sharparrow1)
Comment on attachment 276201 [details] [diff] [review]
Proposed patch

r=me assuming that 4px feels like approximately the right amount.
Attachment #276201 - Flags: review?(sharparrow1) → review+
Attachment #276201 - Flags: superreview?(roc) → superreview+
Comment on attachment 276201 [details] [diff] [review]
Proposed patch

Fix for a noticeable regression that can make tree splitters almost impossible to use.
Attachment #276201 - Flags: approval1.9?
Comment on attachment 276201 [details] [diff] [review]
Proposed patch

a1.9=dbaron
Attachment #276201 - Flags: approval1.9? → approval1.9+
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Duplicate of this bug: 389012
Component: XP Toolkit/Widgets: Trees → XUL
QA Contact: xptoolkit.trees → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.