Closed
Bug 391823
Opened 17 years ago
Closed 17 years ago
mozilla-central: Firefox build fails copying libnssdbm3.dylib to dist/bin
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jorendorff, Assigned: Mardak)
Details
Attachments
(2 files)
269 bytes,
application/octet-stream
|
Details | |
519 bytes,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
It looks like the Firefox build is broken in mozilla-central. I cloned it, I ran client.py, and did "make -f client.mk build". Nothing funny in my .mozconfig file (attached). Result: /Users/jason/dev/am/mozilla-central-ffbuild/obj-ff-debug/config/nsinstall -L /Users/jason/dev/am/mozilla-central-ffbuild/obj-ff-debug/security/manager -m 755 ../../dist/lib/libnssckbi.dylib ../../dist/bin /Users/jason/dev/am/mozilla-central-ffbuild/obj-ff-debug/config/nsinstall -L /Users/jason/dev/am/mozilla-central-ffbuild/obj-ff-debug/security/manager -m 644 ../../dist/lib/libsoftokn3.chk ../../dist/bin /Users/jason/dev/am/mozilla-central-ffbuild/obj-ff-debug/config/nsinstall -L /Users/jason/dev/am/mozilla-central-ffbuild/obj-ff-debug/security/manager -m 755 ../../dist/lib/libsoftokn3.dylib ../../dist/bin /Users/jason/dev/am/mozilla-central-ffbuild/obj-ff-debug/config/nsinstall -L /Users/jason/dev/am/mozilla-central-ffbuild/obj-ff-debug/security/manager -m 755 ../../dist/lib/libnssdbm3.dylib ../../dist/bin /Users/jason/dev/am/mozilla-central-ffbuild/obj-ff-debug/config/nsinstall: cannot access ../../dist/lib/libnssdbm3.dylib: No such file or directory gmake[4]: *** [libs] Error 1 gmake[4]: Leaving directory `/Users/jason/dev/am/mozilla-central-ffbuild/obj-ff-debug/security/manager' gmake[3]: *** [libs_tier_toolkit] Error 2 gmake[3]: Leaving directory `/Users/jason/dev/am/mozilla-central-ffbuild/obj-ff-debug' gmake[2]: *** [tier_toolkit] Error 2 gmake[2]: Leaving directory `/Users/jason/dev/am/mozilla-central-ffbuild/obj-ff-debug' make[1]: *** [default] Error 2 make[1]: Leaving directory `/Users/jason/dev/am/mozilla-central-ffbuild/obj-ff-debug' make: *** [build] Error 2
Comment 1•17 years ago
|
||
Could be that client.mk in CVS is pulling a newer version of NSS and client.py wasn't merged correctly.
Comment 2•17 years ago
|
||
Yes. It appears that when edward.lee@engineering.uiuc.edu did the merge at revision c9881a28179f he failed to merge the client.mk changes from revisions 6d237df4154c or b52f7cd3d855 I don't know who that is or who pushed that changeset, which makes me a little unhappy already ;-)
Assignee | ||
Comment 3•17 years ago
|
||
(In reply to comment #2) > I don't know who that is or who pushed that changeset, which makes me a little > unhappy already ;-) Sorry about that. I'll post a patch in a bit that restores the client.mk changes.
Assignee: nobody → edilee
Assignee | ||
Comment 4•17 years ago
|
||
Update the *_CO_TAGs that were split off from client.mk into client.py (see Bug 387992 for NSPR_CO_TAG; Bug 388403 then Bug 390451 for NSS_CO_TAG) Sorry for not merging those changes correctly the first time -- unfortunate that those checkout tags are right after the directory listing of modules that were removed.
Attachment #276274 -
Flags: review?(benjamin)
Reporter | ||
Comment 5•17 years ago
|
||
Firefox builds for me with that fix. (but delete nsprpub/configure before you re-run "client.py cvheckout")
Comment 6•17 years ago
|
||
Comment on attachment 276274 [details] [diff] [review] fix client.py Thanks. Sorry, I knew you as "Mardak" but didn't know that translated into Edward Lee ;-)
Attachment #276274 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 7•17 years ago
|
||
pushed to hg/mozilla-central changeset 4508: 29d8b72f9a9f merged to hg/actionmonkey changeset 4545: 7f16b7fd242e
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•