If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

button-images are outside the button and squeezed (new DM)

VERIFIED FIXED in mozilla1.9alpha8

Status

()

Toolkit
Downloads API
VERIFIED FIXED
10 years ago
9 years ago

People

(Reporter: Peter6, Assigned: rflint)

Tracking

Trunk
mozilla1.9alpha8
x86
Windows XP
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments)

(Reporter)

Description

10 years ago
Created attachment 276291 [details]
screenshot

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007081115 Minefield/3.0a8pre ID:2007081115
I am guessing this is also causing there to be a horizontal scrollbar when there is no need for one (changing the DM window to any size and the horiz scrollbar is always present)
Assignee: nobody → ryan
Created attachment 276325 [details] [diff] [review]
Patch

Fixes the padding/margin issues and moves all button styling to a new mini-button class - which I'll switch pinstripe over to in another bug.
Attachment #276325 - Flags: review?(sdwilsh)
Created attachment 276326 [details]
Comparison shot
Comment on attachment 276325 [details] [diff] [review]
Patch

Looks good to me.  Just checking to make sure that some of those lines don't wrap more than 80 characters.

I'd also like Mano to look at this because he's the CSS wizard.
Attachment #276325 - Flags: review?(sdwilsh)
Attachment #276325 - Flags: review?(mano)
Attachment #276325 - Flags: review+
Comment on attachment 276326 [details]
Comparison shot

This looks much better - although the pop-up doesn't look quite right still :/ (not this bug, clearly)
Comment on attachment 276325 [details] [diff] [review]
Patch

r=me (fast pass so we can get it into nightlies, hopefully Mano can look a little closer)
Attachment #276325 - Flags: review?(mano) → review+
(Reporter)

Updated

10 years ago
Blocks: 388517
mozilla/toolkit/mozapps/downloads/content/download.xml           1.30 mozilla/toolkit/mozapps/downloads/content/downloads.xul 	 1.25
mozilla/toolkit/themes/winstripe/mozapps/downloads/downloads.css 1.16
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
Target Milestone: --- → Firefox 3 M8
(Reporter)

Comment 8

10 years ago
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007081201 Minefield/3.0a8pre ID:2007081201

VERIFIED
Status: RESOLVED → VERIFIED
Created attachment 276363 [details] [diff] [review]
Clean up
Attachment #276363 - Flags: review?(mano)
Comment on attachment 276363 [details] [diff] [review]
Clean up

r=mano
Attachment #276363 - Flags: review?(mano) → review+
Comment on attachment 276363 [details] [diff] [review]
Clean up

mozilla/toolkit/themes/winstripe/mozapps/downloads/downloads.css 	1.18
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.