391877 - highlight the string (word) you searched for in the results (new DM)

Status: NEW

(Toolkit :: Downloads API, enhancement)

Description

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007081115 Minefield/3.0a8pre ID:2007081115

repro:
download a few files
do a search where more then one file would be the result.

result:
it shows the files, but does not highlight the string you searched for.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Do we really have to highlight the filtered download entries?

Comment 2

[Alex Faaborg [:faaborg] (Firefox UX)]

>uiwanted

This doesn't seem overly needed since in filtering interfaces in the past we have simply filtered, and normally the set of remaining results makes sense without additional context.  Although I'm also not really opposed to the idea either, showing the highlighted area will make it easier for people to visually scan the results faster, similar to the interface currently used in the location bar results.  Also this makes it clear that you are not viewing the complete list (for instance if you return to the window much later).

If we go forward with this, I think we should have a UI more like the location bar results (bold and underlined) as opposed to the find in page UI (kind of a strange shade of green).  Ideally we would be highlighting similar to apps like Safari or Coda, but that's likely more of a platform change outside of the scope of this bug.

Comment 3

[Peter van der Woude [:Peter6]]

(In reply to comment #2)
> >uiwanted
> 
> This doesn't seem overly needed since in filtering interfaces in the past we
> have simply filtered, and normally the set of remaining results makes sense
> without additional context.  Although I'm also not really opposed to the idea
> either, showing the highlighted area will make it easier for people to visually
> scan the results faster, similar to the interface currently used in the
> location bar results.  Also this makes it clear that you are not viewing the
> complete list (for instance if you return to the window much later).
> 
> If we go forward with this, I think we should have a UI more like the location
> bar results (bold and underlined) as opposed to the find in page UI (kind of a
> strange shade of green).  Ideally we would be highlighting similar to apps like
> Safari or Coda, but that's likely more of a platform change outside of the
> scope of this bug.

yeah, the location bar solution of highlighting looks like the best option here.

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Mass-removing myself from cc; search for 12b9dfe4-ece3-40dc-8d23-60e179f64ac1 or any reasonable part thereof, to mass-delete these notifications (and sorry!)