snav crashed with dynamic/multant DOM contents

RESOLVED WORKSFORME

Status

()

Core
Keyboard: Navigation
RESOLVED WORKSFORME
11 years ago
9 years ago

People

(Reporter: Antonio Gomes (tonikitoo), Unassigned)

Tracking

Trunk
x86
Linux
Points:
---
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(3 attachments, 2 obsolete attachments)

(Reporter)

Description

11 years ago
PRECONDITIONS: 
firefox 2 built with 'spatialnavigation' extension enabled.

mozconfig:

_________________________________________
mk_add_options MOZ_CO_PROJECT=browser
ac_add_options --enable-application=browser

ac_add_options --enable-extensions=spatialnavigation
ac_add_options --disable-airbag
_________________________________________


STEPS LEADING TO PROBLEM: 
1. go to 'www.aol.com'
2. Using snav (or not), focus highlight any link in the "featured stories" box near the center/top of the page (see attachment).
   2.1 Note that the contents of this box rotates over time. Allow it to rotate to another content item.
3. Press a navigation key

EXPECTED OUTCOME:
browser does not crash

ACTUAL OUTCOME:
FF2 crashes

FREQUENCY OF OCCURRENCE: 
always
Flags: in-testsuite?
(Reporter)

Comment 1

11 years ago
Created attachment 276498 [details]
frame where crash happens

well ... see frame where crash occurs.

btw, firefox 2 (and also 3) renders this webpage badly, so I sshot'ed it with opera :/
Attachment #276498 - Flags: review?
(Reporter)

Comment 2

11 years ago
Created attachment 276499 [details] [diff] [review]
patch adds some needed NULL point checks into snav
Attachment #276499 - Flags: review?(dougt)
(Reporter)

Updated

11 years ago
Attachment #276498 - Flags: review?

Updated

11 years ago
Attachment #276499 - Flags: review?(dougt) → review+
(Reporter)

Comment 3

11 years ago
doug could you check this in ?
Assignee: tonikitoo → dougt
Keywords: checkin-needed

Comment 4

11 years ago
sure, i can.  The patch above is for the 1.8 branch.  Can you put together a trunk patch really quick and I will land both at the same time.
Component: Keyboard Navigation → Keyboard: Navigation
Product: Firefox → Core
QA Contact: keyboard.navigation → keyboard.navigation
Version: 2.0 Branch → Trunk
(Reporter)

Comment 5

11 years ago
Created attachment 277236 [details] [diff] [review]
patch adds some needed NULL point checks into snav source (v2)

I added some further NULL point checks
Attachment #276499 - Attachment is obsolete: true
(Reporter)

Comment 6

11 years ago
Created attachment 277238 [details] [diff] [review]
patch adds some needed NULL point checks into snav source (v3)

removed wrongly "tab"
Attachment #277236 - Attachment is obsolete: true
Attachment #277238 - Flags: review?(dougt)
(Reporter)

Comment 7

11 years ago
Created attachment 277240 [details] [diff] [review]
patch adds some needed NULL point checks into snav source (trunk - ff3)

snav still fails to build in FF3/trunk (with or without this patch applied) due to bug 347731, however the changes proposed in this patch do not affect it at all, and it can be committed.
Attachment #277240 - Flags: review?(dougt)

Comment 8

11 years ago
I am not sure it is a good idea to land anything on something that can't compile and sort of don't want to have the code diverge.  

Let me go over and comment on 347731.
Keywords: checkin-needed

Comment 9

11 years ago
mass reassigning to nobody.
Assignee: dougt → nobody

Comment 10

10 years ago
Comment on attachment 277238 [details] [diff] [review]
patch adds some needed NULL point checks into snav source (v3)

i no longer support extensions/spatialnavigation.  I rewrote this feature set in js and that is what I am currently using.
Attachment #277238 - Flags: review?(doug.turner) → review-

Updated

10 years ago
Attachment #277240 - Flags: review?(doug.turner) → review-

Comment 11

9 years ago
The code has been rewritten in JS.  The C++ version is no longer in the repo.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.