392099 - unable to search for downloads with % (SQLite MATCH_ALL) or _ (SQLite MATCH_ONE) in the name

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect)

Description

[(not reading, please use [e-mail] instead)]

fix LIKE search to allow for search terms with % _

the solution:

fix this code at http://lxr.mozilla.org/seamonkey/source/toolkit/mozapps/downloads/content/downloads.js#756

sql += "name LIKE '%" + terms[i] + "%' ";

to be:

sql += "name LIKE '%" + stmt.escapeStringForLIKE(terms[i], '/') + "%' ESCAPE '/' ";

Comment 1

[(not reading, please use [e-mail] instead)]

actually, this shouldn't this be something like:

sql += "name LIKE ?1 ESCAPE '/'";

and then bindStringParamer(x, "%" + stmt.escapeStringForLIKE(terms[i], '/') + "%");

see http://lxr.mozilla.org/seamonkey/source/storage/test/unit/test_like_escape.js#56 for an example of how to do this.

Comment 2

[(not reading, please use [e-mail] instead)]

Attachment: patch, also fixes the problem that a search for "foo bar cheese" would match for items containing foo, bar, or cheese and not only items containing "foo bar cheese"

Comment 3

[Shawn Wilsher :sdwilsh]

Comment on attachment 276594 [details] [diff] [review]
patch, also fixes the problem that a search for "foo bar cheese" would match for items containing foo, bar, or cheese and not only items containing "foo bar cheese"

Thanks!  r=sdwilsh

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

http://litmus.mozilla.org/show_test.cgi?id=4573

in-litmus+ for comment 2 only at this time.

Let me know if you find a good, reliable (fixed-location) testcase for comment 0, and I'll write a Litmus testcase and change the ? to +

Comment 5

[(not reading, please use [e-mail] instead)]

stephen, let's just attach a file with the desired name to this bug, and use that.

Comment 6

[(not reading, please use [e-mail] instead)]

Attachment: the name of this file is filename_%_test.zip

Comment 7

[(not reading, please use [e-mail] instead)]

stephen, use https://bugzilla.mozilla.org/attachment.cgi?id=277235 for your litmus test case.

note:  with that test case, a download manager quick search for "%" gives me that file, but a download manager quick search for just "_" does not give me that file, so something is not working right.  (note, a quick earch for "e_" does give me the result.)

so this is not completely fixed.  stephen, can you add the "%" and "_" scenarios to your test litmus test case?

I'll investigate why "_" doesn't work.

Comment 8

[(not reading, please use [e-mail] instead)]

actually, _ might be working, and I might just be running into bug #392386.

Comment 9

[(not reading, please use [e-mail] instead)]

_ is working, I was just hitting #392386.

marking as fixed.

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

http://litmus.mozilla.org/show_test.cgi?id=4574

in-litmus+ now, for both cases (comment 7 and comment 2).

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a8pre) Gecko/2007090405 Minefield/3.0a8pre with both "_" and "%" as search terms (and in conjunction in a separate search query with their surrounding filename characters).