Extensions still in "updated" rss feed during new update are not recognized as new feed item

RESOLVED FIXED

Status

addons.mozilla.org Graveyard
Public Pages
RESOLVED FIXED
10 years ago
a year ago

People

(Reporter: aryx, Assigned: wenzel)

Tracking

Details

(URL)

Attachments

(1 attachment)

ThunderBrowse extension is in development and gets updated often. There is a item for the last update in the feed, but it doesn't get recognized as new by Thunderbird.

Use <guid>...</guid> to solve the problem, I guess.
(Assignee)

Comment 1

10 years ago
True. Any idea on what guid would be useful there?
<add-on id>-<date and time stamp>?
sprintf("%s-%s-%d", addOnGUID, addOnVersion, versionId) ?
(Assignee)

Comment 4

10 years ago
Ah, yeah, the latter sounds like it could work pretty well. I'll see if I can write a patch.
Assignee: nobody → fwenzel
(Assignee)

Comment 5

10 years ago
http://cyber.law.harvard.edu/rss/rss.html#ltguidgtSubelementOfLtitemgt

says the GUID can be a permalink. So I wonder if we should link to something along the lines of:
https://addons.mozilla.org/en-US/firefox/addons/versions/1865#installTrigger7551

... which would in turn make this bug depend on bug 375535?
(Assignee)

Updated

10 years ago
Depends on: 375535
(Assignee)

Comment 6

10 years ago
Created attachment 292746 [details] [diff] [review]
Use version permalink in RSS to distinguish updated feed items

Pending review on attachment 292744 [details] [diff] [review], this patch will use the new permalink anchor in order to give each feed item a permalink as GUID.

Note that this also includes the RSS timestamp fix for bug 375525 (i.e. this bug will fix both issues).
Attachment #292746 - Flags: review?(laura)
(Assignee)

Comment 7

10 years ago
This has been committed to the 3.2 redesign branch as r9312 and merged into trunk as r9313. Marking fixed, needs push. Thanks, all.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Keywords: push-needed
Resolution: --- → FIXED
(Assignee)

Updated

10 years ago
Duplicate of this bug: 411834
(Assignee)

Comment 9

10 years ago
Hm. Though this has been pushed (and it's fixed for the URL above), other feeds (see bug 411834) don't provide a GUID yet. Reopening.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 10

10 years ago
Okay I added a GUID for the categories RSS feed too, SVN r9577. I also fixed the GUID on the "all versions" page, r9579. Push needed.
Status: REOPENED → RESOLVED
Last Resolved: 10 years ago10 years ago
Resolution: --- → FIXED
This is live.
Keywords: push-needed
(Assignee)

Updated

9 years ago
Attachment #292746 - Flags: review?(laura)
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.