bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Remove obuffer size guessing from mimetpla.cpp

VERIFIED FIXED in M17

Status

MailNews Core
MIME
P3
normal
VERIFIED FIXED
18 years ago
10 years ago

People

(Reporter: BenB, Assigned: BenB)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

18 years ago
Code cleanup.

Currently, there're come calculations abotu how large the out buffer could grow
after txt->html transformation. This is a bit bogus, because you just can't
know. We don't even need it, because we use nsString to hold the result anyway,
which grows automatically as needed.

My only concern is, that I don't understand libmime well. Rich, does
obj->obuffer have any side-effect or is it inititalized, used and discarded in
MimeInlineTextPlain_parse_line, i.e. can I savely remove it and just do
something like |tmp = output.ToNewCString(); MimeObject_write(obj, tmp,
output.Length(), PR_TRUE); Recycle(tmp);|?
(Assignee)

Updated

18 years ago
Depends on: 31906
Target Milestone: --- → M18
(Assignee)

Updated

18 years ago
Status: NEW → ASSIGNED
(Assignee)

Updated

18 years ago
Target Milestone: M18 → M17
(Assignee)

Comment 1

18 years ago
Fix checked in by rhp.
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
QA Contact: lchiang → stephend
http://lxr.mozilla.org/seamonkey/search?string=obuffer

obuffer exists in other portions of mime, but not in this file.

Marking Verified FIXED.
Status: RESOLVED → VERIFIED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.