39230 - Give option to set color to "none"

Status: NEW

(Thunderbird :: Preferences, defect)

Description

[Ben Bucksch (:BenB)]

Reproduce:
1. Do *not* set mailnews|viewing messages|quotes plain text appearance|color
2. Create the rule |blockquote { color: red; }| in
|<userprofiledir>/chrome/user.css|.
3. View a plain text msg (not flowed) with a quote.

Actual result:
The quote is displayed black.

Expected result:
The quote is displayed red.

Additional Comments:
This is because the prefs dialog always stores a value. We need an option "Do
not set anything", i.e. an option *not* to seelct a color.

Comment 1

[Ben Bucksch (:BenB)]

This bug in part contradicts the goal of feature bug 31906.

Comment 2

[Ben Bucksch (:BenB)]

Ops, the reproduction is bad. Forget it.

The problem is, that the color picker has no option "select nothing" (i.e.
"select no color"). So if I set the color e.g. to red and then want to restore
the initial setting, it's impossible. I can't get the UI to set "no color"
again, which was (should be) the default.

(The default for mail.citation is currently "#000000", but should be "".)

Comment 3

[Peter Trudelle]

sounds like something for ben, reassigning.

Comment 4

[Ben Bucksch (:BenB)]

ccing color picker owner saari

Comment 5

[Ben Bucksch (:BenB)]

The user cannot reset to the original setting. nsbeta3.

Comment 6

[johng]

nav triage team:
this is a mail question - maybe you default the pref to "black" or just be 
satisfied that the user can switch to black ..... don't care.

reassigning to putterman

Comment 7

[Ben Bucksch (:BenB)]

"black" != no color. "black" overrides whatever the user sat in the stylesheet,
e.g. different colors for different quote levels. That's why I intentionally
changed the default from "black" to "none".

If you don't care - OK, your problem.

Comment 8

[scottputterman]

marking [nsbeta3-]. It's not a high enough priority for this release.

Comment 9

[Christopher Aillon (sabbatical, not receiving bugmail)]

Worksforme.

In userContent.css the blockquote { color: red; } rule works for me to display
quoted mail in red.  This shouldn't even be an XP Apps bug.  User styles should
always override all other styles.  Perhaps the reason we didn't initially was
that we were styling with !important.  If that was the case, you would need an
!important on your user CSS in order to override that.  In general, you should
always use !important in your userChrome.css and userContent.css files to ensure
that your styles are used.

Comment 10

[Ben Bucksch (:BenB)]

You misunderstood this bug. Please see comment 2. It is about the color picker
widget, Mailnews was just an example.

Comment 11

[Christopher Aillon (sabbatical, not receiving bugmail)]

My point is there should not be a reason for a user to ever need to choose
"none".  If you want to override it with a user style, you can.  You only
brought up picking no color as a workaround to the original bug you reported.

Again, as a CSS browser we must either have a color or have inherit set.  But
inheriting will gain us nothing for the problem you reported.  The bottom line
is that users should not have to think about inheritance and all the funkiness
that CSS brings with it.  If you think that this should not be WFM, then IMO it
should be WONTFIX.

Comment 12

[Ben Bucksch (:BenB)]

> My point is there should not be a reason for a user to ever need to choose
> "none".

THere is: Setting a color is different from setting no color, in which case the
color will be determined by other ways, e.g. the browser's default colors. Which
the user can set at a central place. Setting the color here means that the user
has to change it in 2 places each time.

Comment 13

[Christopher Aillon (sabbatical, not receiving bugmail)]

Which two places?

Comment 14

[Ben Bucksch (:BenB)]

Prefs|Appearance|Colors
Prefs|Mailnews|Message Display

Comment 15

[Christian :Biesinger (don't email me, ping me on IRC)]

benb, can you just use !important in your userChrome.css?

Comment 16

[Christopher Aillon (sabbatical, not receiving bugmail)]

helpwanted

Comment 17

[Dave Miller [:justdave]]

wrong nobody

Comment 18

[Mats Palmgren (inactive)]

Seems like Thunderbird UI issue more than an inherent XUL issue.