Closed
Bug 392314
Opened 17 years ago
Closed 17 years ago
alt key should close menu while menubar is activated
Categories
(Core :: XUL, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: enndeakin, Assigned: enndeakin)
References
Details
Attachments
(1 file)
|
5.95 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
dbaron
:
approval1.9+
|
Details | Diff | Splinter Review |
1. Press the Alt key to activate the menubar 2. Press Alt again and the menubar should be deactivated
|
||
Comment 1•17 years ago
|
||
which version of firefox are you using? i try my " Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.6) Gecko/20070814 BonEcho/2.0.0.6 ", it works well
|
|
||
Comment 2•17 years ago
|
||
your bug appear on my build " Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007081614 Minefield/3.0a8pre "
|
Assignee | |
Comment 3•17 years ago
|
||
Make sure to only cancel events while a menu is open, in this bug, a menu isn't open but a menubar is focused. Also, don't look for a keyboard shortcut when no character is pressed (alt pressed by itself) otherwise, the menubar gets deactivation events twice.
Attachment #277421 -
Flags: superreview?(bzbarsky)
Attachment #277421 -
Flags: review?(bzbarsky)
|
||
Comment 4•17 years ago
|
||
Comment on attachment 277421 [details] [diff] [review] handle alt key Makes sense
Attachment #277421 -
Flags: superreview?(bzbarsky)
Attachment #277421 -
Flags: superreview+
Attachment #277421 -
Flags: review?(bzbarsky)
Attachment #277421 -
Flags: review+
|
|
Assignee | |
Updated•17 years ago
|
Attachment #277421 -
Flags: approval1.9?
Comment on attachment 277421 [details] [diff] [review] handle alt key a1.9=dbaron
Attachment #277421 -
Flags: approval1.9? → approval1.9+
|
|
Assignee | |
Updated•17 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Component: XP Toolkit/Widgets: Menus → XUL
QA Contact: xptoolkit.menus → xptoolkit.widgets
You need to log in
before you can comment on or make changes to this bug.
Description
•