392362 - Make a pref to control the number of days for which we display download history.

Status: VERIFIED FIXED

(Toolkit :: Downloads API, enhancement)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Build ID: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a8pre) Gecko/2007081504 Minefield/3.0a8pre

Summary: Make the "only show 7 days worth of downloads" a pref (so I can better test large download files)

Steps to Reproduce:

1. Import a downloads.rdf/downloads.sqlite file by dropping it into your profile folder for a trunk build.
2. Run the trunk build.
3. Open Tools | Downloads.

Expected Results:

Under "Completed", you should see a populated download window.

Actual Results:

Because we currently only display the previous 7 days' worth of download data, it appears blank.

Comment 1

[Ed Lee :Mardak]

Attachment: v1

Adds an int pref browser.download.manager.historyDays

Perhaps there should be something to say "show ## hidden downloads" or "show all ## downloads"

Comment 2

[Shawn Wilsher :sdwilsh]

Comment on attachment 276887 [details] [diff] [review]
v1

just use a default pref, and let's use browser.download.manager.displayedHistoryDays

Comment 3

[Ed Lee :Mardak]

Attachment: v2

(In reply to comment #2)
> just use a default pref
Made default to avoid try/catch
> browser.download.manager.displayedHistoryDays
Renamed and defaulted to 7.

Comment 4

[Shawn Wilsher :sdwilsh]

Please file a bug for thunderbird to add this pref as well.

Checking in toolkit/mozapps/downloads/content/downloads.js;
new revision: 1.80; previous revision: 1.79
Checking in browser/app/profile/firefox.js;
new revision: 1.195; previous revision: 1.194

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

I've been using this for a while; Verified FIXED using Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a8pre) Gecko/2007082923 Minefield/3.0a8pre

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #4)
> Please file a bug for thunderbird to add this pref as well.

Done; I filed bug 394290.

Comment 7

[Shawn Wilsher :sdwilsh]

(In reply to comment #6)
> (In reply to comment #4)
> > Please file a bug for thunderbird to add this pref as well.
> 
> Done; I filed bug 394290.
He already filed it and fixed it (don't have bugnumber handy offhand)