Closed Bug 392362 Opened 16 years ago Closed 16 years ago

Make a pref to control the number of days for which we display download history.

Categories

(Toolkit :: Downloads API, enhancement)

enhancement
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla1.9alpha8

People

(Reporter: stephend, Assigned: Mardak)

Details

Attachments

(1 file, 1 obsolete file)

Build ID: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a8pre) Gecko/2007081504 Minefield/3.0a8pre

Summary: Make the "only show 7 days worth of downloads" a pref (so I can better test large download files)

Steps to Reproduce:

1. Import a downloads.rdf/downloads.sqlite file by dropping it into your profile folder for a trunk build.
2. Run the trunk build.
3. Open Tools | Downloads.

Expected Results:

Under "Completed", you should see a populated download window.

Actual Results:

Because we currently only display the previous 7 days' worth of download data, it appears blank.
Severity: normal → enhancement
OS: Mac OS X → All
Hardware: PC → All
Attached patch v1 (obsolete) — Splinter Review
Adds an int pref browser.download.manager.historyDays

Perhaps there should be something to say "show ## hidden downloads" or "show all ## downloads"
Assignee: nobody → edilee
Status: NEW → ASSIGNED
Attachment #276887 - Flags: review?(sdwilsh)
Comment on attachment 276887 [details] [diff] [review]
v1

just use a default pref, and let's use browser.download.manager.displayedHistoryDays
Attachment #276887 - Flags: review?(sdwilsh) → review-
Attached patch v2Splinter Review
(In reply to comment #2)
> just use a default pref
Made default to avoid try/catch
> browser.download.manager.displayedHistoryDays
Renamed and defaulted to 7.
Attachment #276887 - Attachment is obsolete: true
Attachment #276919 - Flags: review?(sdwilsh)
Attachment #276919 - Flags: review?(sdwilsh) → review+
Please file a bug for thunderbird to add this pref as well.

Checking in toolkit/mozapps/downloads/content/downloads.js;
new revision: 1.80; previous revision: 1.79
Checking in browser/app/profile/firefox.js;
new revision: 1.195; previous revision: 1.194
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: in-testsuite-
Flags: in-litmus-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 M8
Version: unspecified → Trunk
I've been using this for a while; Verified FIXED using Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a8pre) Gecko/2007082923 Minefield/3.0a8pre
Status: RESOLVED → VERIFIED
(In reply to comment #4)
> Please file a bug for thunderbird to add this pref as well.

Done; I filed bug 394290.

(In reply to comment #6)
> (In reply to comment #4)
> > Please file a bug for thunderbird to add this pref as well.
> 
> Done; I filed bug 394290.
He already filed it and fixed it (don't have bugnumber handy offhand)
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.