392376 - Double-clicking on the selected application within the file handling dialog should work as "OK" and launch the application

Status: VERIFIED FIXED

(Firefox :: File Handling, defect, P2)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Build ID: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a8pre) Gecko/2007081504 Minefield/3.0a8pre

I hope this isn't already filed; I searched for "double click" in file handling...

Summary: Double-clicking on the selected application within the file handling dialog should work as "OK" and launch the application.

Steps to Reproduce:

1. Do a File | Send Link.
2. Get the "Launch Application" dialog.
3. Select "Thunderbird"--or whatever program you have associated.
4. Double-click on the application's name.

Expected Results:

Dismisses the dialog and launches the application.

Actual Results:

The double-click event is eaten/trapped, and nothing happens.

Comment 1

[Alex Faaborg [:faaborg] (Firefox UX)]

Yeah, I agree that double clicking should launch the app.

Comment 2

[Mike Connor [:mconnor]]

moving out bugs that don't need to block b1

Comment 3

[Mike Connor [:mconnor]]

UI, want this for M10

Comment 4

[Florian Quèze [:florian] (unavailable until May 22)]

Attachment: patch v1

Comment 5

[Asaf Romano (gone)]

Comment on attachment 288393 [details] [diff] [review]
patch v1

s/document.getElementById("handling")/document.documentElement/

r=mano otherwise.

Comment 6

[Florian Quèze [:florian] (unavailable until May 22)]

Attachment: patch v2 (ready for checkin)

Comment 7

[Reed Loden [:reed]]

Checking in toolkit/mozapps/handling/content/dialog.js;
/cvsroot/mozilla/toolkit/mozapps/handling/content/dialog.js,v  <--  dialog.js
new revision: 1.8; previous revision: 1.7
done
Checking in toolkit/mozapps/handling/content/dialog.xul;
/cvsroot/mozilla/toolkit/mozapps/handling/content/dialog.xul,v  <--  dialog.xul
new revision: 1.5; previous revision: 1.4
done

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b2pre) Gecko/2007111304 Minefield/3.0b2pre

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

https://litmus.mozilla.org/show_test.cgi?id=5005

in-litmus+