Closed Bug 392420 Opened 13 years ago Closed 13 years ago

No DOMi window icon in Firefox

Categories

(Other Applications :: DOM Inspector, defect)

x86
All
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: philor, Assigned: philor)

References

Details

(Keywords: regression)

Attachments

(1 file)

Attached patch Fix v.1Splinter Review
STR:
1. Open DOMi in a Firefox trunk build after bug 379109 landed
2. Note the Firefox (or Minefield, depending on your branding) icon on the left end of the window titlebar, not the intended DOMi red magnifier on a square orange background.

Related (and the reason I saw it): the Windows build logs start with a spew of package errors including "Warning: package error or possible missing or unnecessary file: bin/extensions/inspector@mozilla.org/chrome/icons/default/winInspectorMain.ico (packages-static, 357)."

Not entirely sure who should-and-will review Fx build config for DOMi, but I know bsmedberg loves reviewing my trivial build patches, and that way I can call it Fx front end, and not need approval1.9.
Attachment #276910 - Flags: review?(benjamin)
Attachment #276910 - Flags: review?(benjamin) → review+
browser/installer/windows/packages-static 1.139
browser/installer/unix/packages-static 1.129
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.