392427 - Bookmarks "yellow star" is subtle when the address bar is also yellow

Status: VERIFIED INVALID

(Firefox :: Theme, defect, P4)

Description

[Jesse Ruderman]

If I bookmark an https page by clicking on the star, the star's interior turns from light yellow to more yellow.  I think this change is too subtle.  One way to fix this problem would be to make the interior of the "non-bookmarked" "empty" star white rather than transparent.

Comment 1

[Alex Faaborg [:faaborg] (Firefox UX)]

Yeah, this was a mistake.  Mano: here is a white star non-bookmarked star: https://bugzilla.mozilla.org/attachment.cgi?id=277191

Comment 2

[Asaf Romano (gone)]

Checking in browser/themes/pinstripe/browser/places/starPage.png;
/cvsroot/mozilla/browser/themes/pinstripe/browser/places/starPage.png,v  <--  starPage.png
new revision: 1.2; previous revision: 1.1
done
Checking in browser/themes/winstripe/browser/places/starPage.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/places/starPage.png,v  <--  starPage.png
new revision: 1.2; previous revision: 1.1
done

Comment 3

[Tracy Walker [:tracy]]

verified with - Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a8pre) Gecko/2007091304 Minefield/3.0a8pre

no longer seems like an issue as the star has a "button" background which sets it apart from the https location bar yellow

Comment 4

[Dão Gottwald [:dao]]

Can attachment 277191 [details] be checked in again? For beta 3, even?

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Seems like this was regressed by bug 413806 for Windows, bug 413471 for Linux, and bug 397723 for Mac. I guess we'll need new non-transparent icons for all three platforms? We could just land the placeholder for now, as Dao suggests. 

Comment 6

[Reed Loden [:reed]]

I'm only going to land it on winstripe for now. I'm sure the Tango team can get a fixed icon very quickly, and maybe the pinstripe team can, too. If we run out of time, we can land the placeholder icon on all three platforms, but it definitely would look ugly, as the icons are different on all three platforms.

Comment 7

[Reed Loden [:reed]]

Checking in browser/themes/winstripe/browser/places/starPage.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/places/starPage.png,v  <--  starPage.png
new revision: 1.4; previous revision: 1.3
done

Comment 8

[Reed Loden [:reed]]

(Note that schrep gave approval for the re-landing of the icon for Beta 3 in bug 392682, where the icon is located.)

Comment 9

[Lapo Calamandrei]

Attachment: Package with the new unselected star in png and svg

Here's a new unselected star with some tweakings too make it less evident. Using a white star is a no go imho since it will look more evident then the golden one on dark backgrounds.

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

Doesn't block beta 3, but we'll likely accept checkins on replacement images up until we cut the tree for building.

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 301249 [details]
Package with the new unselected star in png and svg

uir+a=beltzner

Comment 12

[Reed Loden [:reed]]

Checking in browser/themes/gnomestripe/browser/places/starPage.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/places/starPage.png,v  <--  starPage.png
new revision: 1.4; previous revision: 1.3
done

Comment 13

[Alex Faaborg [:faaborg] (Firefox UX)]

>I'm only going to land it on winstripe for now. I'm sure the Tango team can get
>a fixed icon very quickly, and maybe the pinstripe team can, too.

Note that this isn't an issue for pinstripe, since it is using an outline star and a filled in star to denote bookmarked vs. un-bookmarked.

Comment 14

[Oakwine]

(In reply to comment #13)

> Note that this isn't an issue for pinstripe, since it is using an outline star
> and a filled in star to denote bookmarked vs. un-bookmarked.

It *could* become an issue on the Mac, if they choose to address Bug 414868 – The grey bookmarking star in proto is confusing.

Comment 16

[Alex Faaborg [:faaborg] (Firefox UX)]

Note that this issue might go away based on the result of bug 417844

Comment 17

[Mike Connor [:mconnor]]

Not blocking on this bug for final ship. Would take a safe enough patch if one comes through.

Comment 18

[Elmar Ludwig]

Is this still an issue now that the yellow background for SSL sites has been removed from the location bar?