39248 - none of the overlays in the ns tree are working

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect, P1)

Description

[(not reading, please use [e-mail] instead)]

there was a big chrome re-org this weekend, I'll investigate what happened to
the absynch ui.

Comment 1

[(not reading, please use [e-mail] instead)]

marking m16, p1.  this blocks rhp's work for m16 for ab synch

Comment 2

[Dan M]

I can help, since putting this on the doorstep of yesterday's chrome reorg is 
probably fair. Need less jargon. What's an absync? How do I tell it's broken?

Comment 3

[(not reading, please use [e-mail] instead)]

danm, thanks for commenting, but don't worry about it.

I should be able to fix it.  

hopefully the rest of the ns tree is ok (except for ab synch ui.)

Comment 4

[(not reading, please use [e-mail] instead)]

none of the overlays are working, so aim doesn't show up in prefs, the task bar,
or in menus.
this is causing a bunch of problems.  marking smoketest and blocker.

I'll continue to investigate, but re-assigning to danm, cc hyatt.

also cc the aim folk, so they know what is going on tomorrow, if we don't fix it
by then.

Comment 5

[(not reading, please use [e-mail] instead)]

when all else fails, cc waterson.

Comment 6

[(not reading, please use [e-mail] instead)]

debugging nsChromeRegistry.cpp now, seeing what file it is trying to load. 

Comment 7

[(not reading, please use [e-mail] instead)]

here's what's going on:

we are trying to load 
file:///builds/sspitzer/seamonkey/ns/dist/bin/chrome/global/content/overlays.rdf
but the file is really:
file:///builds/sspitzer/seamonkey/ns/dist/bin/chrome/packages/widget-toolkit/global/content/overlays.rdf

another example:
file:///builds/sspitzer/seamonkey/ns/dist/bin/chrome/messenger/content/overlays.rdf
when the file is .
file:///builds/sspitzer/seamonkey/ns/dist/bin/chrome/packages/messenger/messenger/content/overlays.rdf

is this hyatt or waterson or danm?

Comment 8

[David Hyatt]

overlays.rdf were always a hack.  We need to remove them from the build and move 
their info into manifest.rdf files.

Comment 9

[Jon Granrose]

so what's the current status on this?  is it still a blocker?  still a smoketest 
blocker we need to keep the tree closed for today?

Comment 10

[timeless]

FYI absync= address book synch. [I think it's important to answer these 
questions as they're asked].

Comment 11

[(not reading, please use [e-mail] instead)]

if this is not fixed, then this is still a blocker, for the ns tree.

Comment 12

[(not reading, please use [e-mail] instead)]

hyatt, what info needs to move into the manifest.rdf file?

Comment 13

[Jon Granrose]

I'm holding the commercial tree for this.

Comment 14

[Peter Trudelle]

changing nomination to dogfood, and plussing.

Comment 15

[Dan M]

Fixed in windows and unix trees, but not the Macintosh. I expect to work with 
saari on the Mac on the 16th. It's going to be another several hours' work. Hmmm. 
We'll want to consider opening the tree regardless. More thinking about that 
after we go sleep, perchance to wake.

Comment 16

[Dan M]

*** Bug 38559 has been marked as a duplicate of this bug. ***

Comment 17

[(not reading, please use [e-mail] instead)]

I just checked in a fix to the right manifest.rdf file to get the absynch ui to 
work again.

are overlays.rdf obsolete?  if so, we should remove them from the ns tree.

Comment 18

[Dan M]

.

Comment 19

[lchiang]

mark verified 

Comment 20

[scalkins]

Reopening for Mac only. Problem persists on that platform. Still causes issues 
with IM missing in Tasks and switcher.

Comment 21

[Alex Musil]

Actually, the IM case on the Mac is due to : http://bugzilla.mozilla.org/
show_bug.cgi?id=40654

This bug should be closed.

Comment 22

[esther]

For this bug the Address Book Sync button is still not on the toolbar in the 
Address Book window on Mac.  So I will verify this and add the part about the 
missing Address Book Sync button to the other bug 40654.