392573 - Most CSS files are missing from Dusk/, flooding web server error logs

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[timeless]

http://mxr-test.landfill.bugzilla.org/bugzilla/search?string=ie-fixes.css&filter=_skin

Found one matching line

ie-fixes.css
/template/en/default/global/header.html.tmpl, 
line 169 -- <link href="skins/contrib/[% contrib_skin FILTER html %]/IE-fixes.css"

This page was automatically generated by MXR-test. 

http://mxr-test.landfill.bugzilla.org/bugzilla/find?string=ie-fixes.css

If you can't find what you're looking for, you can always search for it.

/skins/standard/IE-fixes.css

This page was automatically generated by MXR-test. 

File does not exist: /var/www/html/bugzilla-tip/skins/contrib/Dusk/IE-fixes.css, referer: http://landfill.bugzilla.org/bugzilla-tip/show_bug.cgi?id=1238

This is flooding our logs because we're being attacked. the file should be added even if it's empty.

Comment 1

[Frédéric Buclin]

I was going to file this bug last night, but was too busy fixing another bug. I agree, even my own error log is getting big with only a very low activity on it. I cannot imagine how big active installations must flood their web server logs. I think timeless is right, we should add all missing CSS files, even if they are empty. Marc, Max, agree?

Comment 2

[timeless]

[Fri Aug 17 05:44:31 2007] [error] [client 65.55.165.91] File does not exist: /var/www/html/bugzilla-tip/skins/contrib/Dusk/dependency-tree.css, referer: http://landfill.bugzilla.org/bugzilla-tip/showdependencytree.cgi?id=1403&hide_resolved=1

Comment 3

[timeless]

[Fri Aug 17 05:49:52 2007] [error] [client 207.46.98.115] File does not exist: /var/www/html/alternate_skin/directory

Comment 4

[Teemu Mannermaa (:wicked)]

Shouldn't checksetup.pl create the CSS files that are missing? It's already creating missing custom CSS files based on the standard CSS files present on the system. See Bugzilla/Install/Filesystem.pm aroung line 203.

Comment 5

[Frédéric Buclin]

(In reply to comment #4)
> Shouldn't checksetup.pl create the CSS files that are missing?

Ah yes, even better. Let's do that! :)

Comment 6

[Marc Schumann [:Wurblzap]]

Yeah, wicked's idea is good.

Comment 7

[Marc Schumann [:Wurblzap]]

Attachment: Patch

Comment 8

[Frédéric Buclin]

Comment on attachment 277085 [details] [diff] [review]
Patch

>+        foreach my $standard_css_file (<$skinsdir/standard/*.css>) {
>+            my $standard_css_file = basename($standard_css_file);

Remove the 2nd "my" as $standard_css_file is already defined in foreach. Works fine on both 3.0.1 and 3.1.1. r=LpSolit

Comment 9

[Marc Schumann [:Wurblzap]]

Fixed comment in spirit.

Tip:
Checking in Bugzilla/Install/Filesystem.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/Filesystem.pm,v  <--  Filesystem.pm
new revision: 1.22; previous revision: 1.21
done

Branch:
Checking in Bugzilla/Install/Filesystem.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/Filesystem.pm,v  <--  Filesystem.pm
new revision: 1.18.2.2; previous revision: 1.18.2.1
done

Comment 10

[Max Kanat-Alexander]

Actually, the skins system should probably "know" what files are available and what are missing, and just not <link> them, but I suppose we can do that later.