392609 - InitUserID() leaks ID string

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Boris Zbarsky [:bzbarsky]]

463                       nsCAutoString id_str(id.ToString());

Leaks.  The header docs on ToString() say:

  Caller should free string.

Note that the best way to fix this depends on what happens in bug 392526.

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Ted: Could you have a look at this, should be an easy fix.

Comment 2

[(not currently active) Ted Mielczarek]

Attachment: PR_Free the pointer

Simple fix.

Comment 3

[Benjamin Smedberg]

Comment on attachment 286006 [details] [diff] [review]
PR_Free the pointer

You want nsAdoptingCString, I think.

Comment 4

[(not currently active) Ted Mielczarek]

is that true?  In bug 392526 bz said:
"2)  The function uses an allocator which is not necessarily compatible with
    XPCOM strings (though in the common case it is).  As a result, Adopt() of
    this string is wrong."

Comment 5

[Benjamin Smedberg]

well shoot, we shoulda fixed bug 331165 already :-(

You should be able to skip the nsCAutostring copy and do something like

nsDependentCString id_str(id_cstr);

Comment 6

[(not currently active) Ted Mielczarek]

Attachment: + nsDependentCString

Same thing, but using nsDependentCString.

Comment 7

[(not currently active) Ted Mielczarek]

Comment on attachment 286750 [details] [diff] [review]
+ nsDependentCString

Looking for approval, just a simple leak fix.

Comment 8

[(not currently active) Ted Mielczarek]

Checked in.