https add-on install from filepicker crashes [@ net_GetURLSpecFromFile]

RESOLVED FIXED in mozilla1.9alpha8

Status

()

--
critical
RESOLVED FIXED
11 years ago
8 years ago

People

(Reporter: tuukka.tolvanen, Assigned: timeless)

Tracking

({crash})

Trunk
mozilla1.9alpha8
x86
Linux
crash
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(crash signature)

Attachments

(2 attachments)

(Reporter)

Description

11 years ago
1. menu: tools -> add-ons
 2. button: Install...
 3. paste an add-on url as the location, I used https://addons.mozilla.org/en-US/thunderbird/downloads/file/15307/adblock_plus-0.7.5.1-fx+tb+sm+fl.xpi

result: crash
expected: "Software installation" dialog, same as if link dragged from fx to tbird add-ons window

tbird trunk 2007-08-15-21Z linux
(Reporter)

Comment 1

11 years ago
TB35040201H
(Reporter)

Updated

11 years ago
Summary: https add-on install from filepicker crashes → https add-on install from filepicker crashes [@ net_GetURLSpecFromFile]
(Reporter)

Comment 2

11 years ago
Created attachment 277154 [details]
trunk bt full
(Assignee)

Updated

11 years ago
Severity: normal → critical
Component: General → Networking
Product: Thunderbird → Core
QA Contact: general → networking
(Assignee)

Comment 3

11 years ago
Created attachment 277255 [details] [diff] [review]
null checks

nsStandardURL::SetFile and nsFileProtocolHandler::NewFileURI are buggy according to biesi.
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #277255 - Flags: superreview?(cbiesinger)
Attachment #277255 - Flags: review?(cbiesinger)
Comment on attachment 277255 [details] [diff] [review]
null checks

was it code in our tree that passed null to these functions?
Attachment #277255 - Flags: superreview?(cbiesinger)
Attachment #277255 - Flags: superreview+
Attachment #277255 - Flags: review?(cbiesinger)
Attachment #277255 - Flags: review+
ah, looks like it... seems like it would be more important to fix that code than the callee here.
(Assignee)

Updated

11 years ago
Attachment #277255 - Flags: approval1.9?
Comment on attachment 277255 [details] [diff] [review]
null checks

a=bzbarsky, but make sure bugs are filed on the callers.
Attachment #277255 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
This was checked-in by timeless at 2007-09-05 03:22, which I think means it made M8. Leaving open to deal with comment #6.
Keywords: checkin-needed
Target Milestone: --- → mozilla1.9 M8

Comment 8

11 years ago
Should we just close this bug and open any new ones on callers?
Comment on attachment 277255 [details] [diff] [review]
null checks

Resetting all approval1.9+ flags on bugs that have not been checked in by Oct 22 11:59 PM PDT.  Please re-request approval if needed.
Attachment #277255 - Flags: approval1.9+
Comment on attachment 277255 [details] [diff] [review]
null checks

Checked-in by timeless at 2007-09-05 03:22.
Attachment #277255 - Flags: approval1.9?
Comment on attachment 277255 [details] [diff] [review]
null checks

Reset approval flag to + as it was already checked in.
Attachment #277255 - Flags: approval1.9? → approval1.9+
Filed bug 433033 on thunderbird.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Crash Signature: [@ net_GetURLSpecFromFile]
You need to log in before you can comment on or make changes to this bug.