Closed
Bug 392649
Opened 18 years ago
Closed 17 years ago
https add-on install from filepicker crashes [@ net_GetURLSpecFromFile]
Categories
(Core :: Networking, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha8
People
(Reporter: tuukka.tolvanen, Assigned: timeless)
Details
(Keywords: crash)
Crash Data
Attachments
(2 files)
|
33.95 KB,
text/plain
|
Details | |
|
1.25 KB,
patch
|
Biesinger
:
review+
Biesinger
:
superreview+
damons
:
approval1.9+
|
Details | Diff | Splinter Review |
1. menu: tools -> add-ons
2. button: Install...
3. paste an add-on url as the location, I used https://addons.mozilla.org/en-US/thunderbird/downloads/file/15307/adblock_plus-0.7.5.1-fx+tb+sm+fl.xpi
result: crash
expected: "Software installation" dialog, same as if link dragged from fx to tbird add-ons window
tbird trunk 2007-08-15-21Z linux
|
Reporter | |
Comment 1•18 years ago
|
||
TB35040201H
|
|
Reporter | |
Updated•18 years ago
|
Summary: https add-on install from filepicker crashes → https add-on install from filepicker crashes [@ net_GetURLSpecFromFile]
|
|
Reporter | |
Comment 2•18 years ago
|
||
Severity: normal → critical
Component: General → Networking
Product: Thunderbird → Core
QA Contact: general → networking
nsStandardURL::SetFile and nsFileProtocolHandler::NewFileURI are buggy according to biesi.
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #277255 -
Flags: superreview?(cbiesinger)
Attachment #277255 -
Flags: review?(cbiesinger)
|
||
Comment 4•18 years ago
|
||
Comment on attachment 277255 [details] [diff] [review]
null checks
was it code in our tree that passed null to these functions?
Attachment #277255 -
Flags: superreview?(cbiesinger)
Attachment #277255 -
Flags: superreview+
Attachment #277255 -
Flags: review?(cbiesinger)
Attachment #277255 -
Flags: review+
|
|
||
Comment 5•18 years ago
|
||
ah, looks like it... seems like it would be more important to fix that code than the callee here.
Attachment #277255 -
Flags: approval1.9?
|
||
Comment 6•18 years ago
|
||
Comment on attachment 277255 [details] [diff] [review]
null checks
a=bzbarsky, but make sure bugs are filed on the callers.
Attachment #277255 -
Flags: approval1.9? → approval1.9+
|
||
Updated•18 years ago
|
Keywords: checkin-needed
|
|
||
Comment 7•18 years ago
|
||
This was checked-in by timeless at 2007-09-05 03:22, which I think means it made M8. Leaving open to deal with comment #6.
Keywords: checkin-needed
Target Milestone: --- → mozilla1.9 M8
|
|
||
Comment 8•18 years ago
|
||
Should we just close this bug and open any new ones on callers?
|
||
Comment 9•18 years ago
|
||
Comment on attachment 277255 [details] [diff] [review]
null checks
Resetting all approval1.9+ flags on bugs that have not been checked in by Oct 22 11:59 PM PDT. Please re-request approval if needed.
Attachment #277255 -
Flags: approval1.9+
|
|
||
Comment 10•18 years ago
|
||
Comment on attachment 277255 [details] [diff] [review]
null checks
Checked-in by timeless at 2007-09-05 03:22.
Attachment #277255 -
Flags: approval1.9?
|
|
||
Comment 11•18 years ago
|
||
Comment on attachment 277255 [details] [diff] [review]
null checks
Reset approval flag to + as it was already checked in.
Attachment #277255 -
Flags: approval1.9? → approval1.9+
|
||
Comment 12•17 years ago
|
||
Filed bug 433033 on thunderbird.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
||
Updated•14 years ago
|
Crash Signature: [@ net_GetURLSpecFromFile]
You need to log in
before you can comment on or make changes to this bug.
Description
•