392649 - https add-on install from filepicker crashes [@ net_GetURLSpecFromFile]

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Tuukka Tolvanen (sp3000)]

1. menu: tools -> add-ons
 2. button: Install...
 3. paste an add-on url as the location, I used https://addons.mozilla.org/en-US/thunderbird/downloads/file/15307/adblock_plus-0.7.5.1-fx+tb+sm+fl.xpi

result: crash
expected: "Software installation" dialog, same as if link dragged from fx to tbird add-ons window

tbird trunk 2007-08-15-21Z linux

Comment 1

[Tuukka Tolvanen (sp3000)]

TB35040201H

Comment 2

[Tuukka Tolvanen (sp3000)]

Attachment: trunk bt full

Comment 3

[timeless]

Attachment: null checks

nsStandardURL::SetFile and nsFileProtocolHandler::NewFileURI are buggy according to biesi.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 277255 [details] [diff] [review]
null checks

was it code in our tree that passed null to these functions?

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

ah, looks like it... seems like it would be more important to fix that code than the callee here.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 277255 [details] [diff] [review]
null checks

a=bzbarsky, but make sure bugs are filed on the callers.

Comment 7

[Reed Loden [:reed]]

This was checked-in by timeless at 2007-09-05 03:22, which I think means it made M8. Leaving open to deal with comment #6.

Comment 8

[Mike Schroepfer]

Should we just close this bug and open any new ones on callers?

Comment 9

[Damon Sicore (:damons)]

Comment on attachment 277255 [details] [diff] [review]
null checks

Resetting all approval1.9+ flags on bugs that have not been checked in by Oct 22 11:59 PM PDT.  Please re-request approval if needed.

Comment 10

[Reed Loden [:reed]]

Comment on attachment 277255 [details] [diff] [review]
null checks

Checked-in by timeless at 2007-09-05 03:22.

Comment 11

[Damon Sicore (:damons)]

Comment on attachment 277255 [details] [diff] [review]
null checks

Reset approval flag to + as it was already checked in.

Comment 12

[:Gavin Sharp [email: [e-mail]]]

Filed bug 433033 on thunderbird.