39271 - [FIXED] NS_IMPL_QUERY_INTERFACE is deprecated

Status: VERIFIED FIXED

(MailNews Core :: MIME, defect, P3)

Description

[Joerg.Brunsmann]

as you can see in

  http://lxr.mozilla.org/mozilla/source/xpcom/base/nsISupportsUtils.h#495

the macro NS_IMPL_QUERY_INTERFACE is deprecated.
The new macro-based QI allows to switch to a
table driven solution.
The following patch switches to NS_IMPL_ISUPPORTS1

Index: mailnews/mime/cthandlers/signstub/nsMimeContentTypeHandler.cpp
===================================================================
RCS file:
/cvsroot/mozilla/mailnews/mime/cthandlers/signstub/nsMimeContentTypeHandler.cpp,v
retrieving revision 1.2
diff -r1.2 nsMimeContentTypeHandler.cpp
52c52
<  * The following macros actually implement addref, release and 
---
>  * The following macro actually implements addref, release and 
55,57c55
< NS_IMPL_ADDREF(nsMimeContentTypeHandler)
< NS_IMPL_RELEASE(nsMimeContentTypeHandler)
< NS_IMPL_QUERY_INTERFACE(nsMimeContentTypeHandler,
NS_GET_IID(nsIMimeContentTypeHandler)); /* we need to pass in the interface ID
of this interface */
---
> NS_IMPL_ISUPPORTS1(nsMimeContentTypeHandler, nsIMimeContentTypeHandler)

Comment 1

[Joerg.Brunsmann]

NS_IMPL_QUERY_INTERFACE is also used in

/mailnews/mime/abstatus/src/nsMimeMiscStatus.cpp, line 48

Comment 2

[rhp (gone)]

Thanks. I am not going to bother with nsMimeMiscStatus since that isn't really 
part of the product anymore.

- rhp

Comment 3

[rhp (gone)]

This made its way into the tree on another major landing.

- rhp

Comment 4

[rhp (gone)]

This made its way into the tree on another major landing.

- rhp

Comment 5

[[e-mail] (gone - use [e-mail] instead)]

That macro is not in /mime anymore (but exists in other portions of mail/news,
seperate bug though).

http://lxr.mozilla.org/seamonkey/search?string=NS_IMPL_QUERY_INTERFACE

Verified FIXED