392736 - Invite Attendees dialog: clicking on address card icon should open Address Book window

Status: NEW

(Calendar :: Dialogs, enhancement)

Description

[juergen.edner]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1.6) Gecko/20070725 Firefox/2.0.0.6
Build Identifier: Thunderbird v2.0.0.6 (20070728) / Lightning v0.7pre (2007081804)

If the 'Invite attendees' button is pressed in a 'new event' dialog it is not possible to add attendees/contacts by pressing the 'address card'.


Reproducible: Always

Steps to Reproduce:
1. create a new event
2. press the 'Invite attendees' button
3. press the 'address card'
Actual Results:  
no address book dialog opens to select attendees/contacts.

Expected Results:  
an address book dialog opens and it is possible to select attendees/contacts from the Thunderbird address book.

Comment 1

[Martin Schröder [:mschroeder]]

Cc'ing Christian. What is your opinion on this issue?

Comment 2

[Stefan Sitter [:ssitter]]

I just tested it with Lightning 0.7pre (2007083103). After typing the first few characters the full name and email address was automatically completed with the address book entry. 

This is the same behavior as during writing emails in the Compose window. As far as I know you can't open the address book but need to type each address manually too.

Comment 3

[Philipp Kewisch [:Fallen][☁️📆]]

The compose window has a sidebar for contacts, but I don't really know how this would fit in with the attendee dialog. Maybe we could somehow extend the addressbook, adding a button to add the contact as an attendee, as long as the window is open.

Comment 4

[Przemyslaw Bialik]

Confirming the bug.

I think the best solution for ease of use and parity would be to mimic compose window (add Contacts button to Invite Attendees dialog which when clicked would open sidebar with contacts and temporary shrink attendees list and/or timebar).
Contacts Sidebar extension (http://jpeters.no-ip.com/extensions/index.php?page=tb_cs) might be helpful in fixing this bug.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Oops, sorry, my bad, returning to the right component, awfully sorry about stomping your target milestone, please send hatemail to this address :(

Comment 6

[u186330]

(In reply to comment #2)
> I just tested it with Lightning 0.7pre (2007083103). After typing the first few
> characters the full name and email address was automatically completed with the
> address book entry.

The standalone application has no address book (I couldn't find one anyway). Integration with Fx address book is OK. However there's another way to find calendars --- via the calendaring server. The "Find calendar..." menu item does just that. It is important to be able to use these results also, since they contain calendars for resources (conference rooms etc) that don't normally go into peoples' address books. Currently one can only subscribe to calendars thus found, not invite them to events or anything else.

Comment 7

[Philipp Kewisch [:Fallen][☁️📆]]

This is rather a feature than a bug. A contacts sidebar for the invite attendees dialog should not block 1.0. I think we should start this out as an extension to experiment. Maybe we could even make the Thunderbird contacts sidebar be reusable so we can just hang it into our dialog.

I don't think this is required for tb-integration. Its a nice feature, but I think we can live without it for an integrated version.

Comment 8

[Przemyslaw Bialik]

(In reply to comment #7)
> philipp:  	 blocking‑calendar1.0-
Without this bug fixed it's problematic when you want to invite more people to the event, "advanced" users could workaround it by creating mailing lists but then there is Bug 419804 ...
Maybe at least Bug 419804 could block 1.0 ?
(currently I'm getting: "recipient address rejected: need fully-qualified address")

Comment 9

[Philipp Kewisch [:Fallen][☁️📆]]

Could you explain more what kind of error you are getting? (i.e paste the full error) I get no errors when entering attendees in the dialog, I can invite as many as I like.

What calendar type are you using (Local, Google Calendar, WCAP, ... ?)

Comment 10

[Przemyslaw Bialik]

(In reply to comment #9)
> I get no errors when entering attendees in the dialog, I can invite as
> many as I like.
please note that I was talking about problems when using mailing lists and apparently you weren't ?

> What calendar type are you using (Local, Google Calendar, WCAP, ... ?)
local calendar on latest trunk ver of TB+LN

Comment 11

[Philipp Kewisch [:Fallen][☁️📆]]

(In reply to comment #10)
> (In reply to comment #9)
> > I get no errors when entering attendees in the dialog, I can invite as
> > many as I like.
> please note that I was talking about problems when using mailing lists and
> apparently you weren't ?
Indeed I wasn't. This bug contains a lot of different ideas, the most simple being clicking on the addressbook symbol to open the addressbook and the most complex being a sidebar.

I guess I can live with the simplest solution, but I won't block 1.0 for it. I'm sure there is a useful action for the ab card on the attendee, but letting each one do the same action doesn't really make sense.

Since the dialog is not modal, I think its a valid workaround to switch to the main window and hit Ctrl+Shift+B.

While Bug 419804 would also be nice to fix, I think its not trivial and don't believe we should let it block 1.0 unless we have a driver for that feature.