39274 - Get rid of non-macro implementations of |QueryInterface|

Status: RESOLVED WONTFIX

(Core :: XPCOM, defect, P3)

Description

[Joerg.Brunsmann]

Bug # 23737 aims at implementing |QueryInterface| with a single table-driven
implementation. In order get a step closer to this table-driver approach,
one must make sure that every component implements |QueryInterface| with
a macro defined in 

http://lxr.mozilla.org/seamonkey/source/xpcom/base/nsISupportsUtils.h

This bug is an attempt to collect patches which eliminates non-macro
implementations of |QueryInterface|

Comment 1

[Suresh Duddi (gone)]

Scott, you want to be owner of this. Help will be greatly appreciated.

Comment 2

[Joerg.Brunsmann]

Attachment: First patch for mozilla/editor

Comment 3

[Suresh Duddi (gone)]

Whats this scc-obsolete anyway.

Comment 4

[Joerg.Brunsmann]

Attachment: Small patch for mozilla/db

Comment 5

[Joerg.Brunsmann]

Attachment: Patch for mozilla/dom

Comment 6

[Joerg.Brunsmann]

Trying to change the cc-mail address to [e-mail]

How do you expect a table driven |QueryInterface| for something like this

http://lxr.mozilla.org/seamonkey/source/netwerk/cache/mgr/nsCachedNetData.cpp#142

How do you expect a table driven |AggregatedQueryInterface|?

How do you expect a table driven |QueryInterface| if the implementor has
additional program logic in |QueryInterface| like:

http://lxr.mozilla.org/seamonkey/source/layout/html/content/src/nsHTMLFormElement.cpp#212

(Click on the NS_IMPL_HTML_CONTENT_QUERY_INTERFACE macro and then on the 
NS_IMPL_CONTENT_QUERY_INTERFACE macro to see the additional logic)

Comment 7

[Asa Dotzler [:asa]]

setting status to NEW

Comment 8

[Scott Collins]

alecf: you've been looking into this (as per bug #23737), so perhaps you want to
own this bug?

Comment 9

[Alec Flett]

I think most of the cases we can change have long since been fixed. I'm marking
this WONTFIX