392845 - Firefox confvars.sh includes xml-rpc as a default extension

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

See the patch ... the xml-rpc extension is not being mirrored in hg.mozilla.org/cvs-trunk-mirror, and I think it's not intended to be part of Firefox going forward. Is that right?

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Comment 2

[Benjamin Smedberg]

Comment on attachment 277355 [details] [diff] [review]
fix

r=me for mozilla-central

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

So Firefox 3 is going to ship with xml-rpc? I thought we were removing it?

Comment 4

[Brendan Eich [:brendan]]

(In reply to comment #3)
> So Firefox 3 is going to ship with xml-rpc? I thought we were removing it?

You may be thinking of SOAP/WSDL (bug 332174). But you raise a good point. Sayrer?

/be

Comment 5

[Robert Sayre]

I'm sure people actually use the xml-rpc component (the poor souls). It's written in JS, so I don't think it's a big deal either way.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Why hasn't it been imported to Mercurial, then?

Comment 7

[Brendan Eich [:brendan]]

Because we were trying to lighten the load for Mozilla 2. If we think it's ok to keep a JS impl of xml-rpc around, I need an owner (being written in JS doesn't mean you can do without that). And we need evidence that xml-rpc is actually used enough to be worth bundling (that too is not a free ride just because the module in question written in JS).

Cc'ing more people for input on whether/when to remove xml-rpc.

/be

Comment 8

[Robert Sayre]

Well, I should have said I was sure people used XML-RPC. Not sure that they're using our component.

A search on mozilla.dev.extensions shows no hits for xml-rpc. 

Flock uses their own component:
http://cvs-mirror.flock.com/index.cgi/mozilla/browser/components/flock/xmlrpc/

ScribeFire uses a component derived from Flock's code.

Those are probably the two most serious XML-RPC users in the Mozilla ecosystem. Let's drop it.

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 277355 [details] [diff] [review]
fix

Okay then, can I get review to check this into CVS for 1.9?

Comment 10

[Benjamin Smedberg]

Comment on attachment 277355 [details] [diff] [review]
fix

r=me for cvs-trunk as well, then. We should probably post to .planning/.platform with this decision.

Comment 11

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in

Comment 12

[:Gavin Sharp [email: [e-mail]]]

You should also remove nsXmlRpcClient.js and xml-rpc.xpt from browser/installer/windows/packages-static and browser/installer/unix/packages-static , no?

Comment 13

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix packages-static

Comment 14

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in