bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Kill old gfx code in nsIImage

RESOLVED FIXED in mozilla1.9alpha8

Status

Core Graveyard
Image: Painting
RESOLVED FIXED
11 years ago
9 years ago

People

(Reporter: Jonathan Steele, Assigned: Jonathan Steele)

Tracking

Trunk
mozilla1.9alpha8
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

1.37 KB, patch
Stuart Parmenter
: review+
Stuart Parmenter
: approval1.9+
Details | Diff | Splinter Review
(Assignee)

Description

11 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007082005 Minefield/3.0a8pre
Build Identifier: 

Remove all the old, dead gfx code from nsIImage. I had a patch for it. 


Reproducible: Always

Steps to Reproduce:
1.
2.
3.
(Assignee)

Comment 1

11 years ago
Created attachment 277428 [details] [diff] [review]
Patch v1.0
You should request review from Stuart by going to the "Details" page for the attachment, setting the "review" line to "?", and entering the email "pavlov@pavlov.net" after it.
(Assignee)

Updated

11 years ago
Attachment #277428 - Flags: review?(pavlov)
(Assignee)

Updated

11 years ago
Attachment #277428 - Attachment is obsolete: true
Attachment #277428 - Flags: review?(pavlov)
(Assignee)

Comment 3

11 years ago
Created attachment 277441 [details] [diff] [review]
Patch v1.1
Attachment #277441 - Flags: review?(pavlov)

Comment 4

11 years ago
Nice.

Some more followup: 
GetIsRowOrderTopToBottom() now always returns PR_TRUE, so we can remove this, and the callers can now always assume TopToBottom (as long as we use Cairo).
Created bug 393001 for this.
(Assignee)

Updated

11 years ago
Component: GFX → Image: GFX
Assignee: nobody → xfsunoles
Status: UNCONFIRMED → NEW
Ever confirmed: true

Updated

11 years ago
Attachment #277441 - Flags: review?(pavlov) → review+

Updated

11 years ago
Attachment #277441 - Flags: approval1.9+
(Assignee)

Updated

11 years ago
Status: NEW → ASSIGNED
Keywords: checkin-needed

Comment 5

11 years ago
mozilla/gfx/public/nsIImage.h  1.30


Please diff from the mozilla/ dir (i.e. cd ~/mozilla;cvs diff -up8 path/to/changed/files > patch). It makes it easier to check patches in.

Also, after editing the patch by hand, please make sure it still applies. Yours gave me "patch unexpectedly ends in middle of line".
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M8
Version: unspecified → psm2.4

Updated

11 years ago
Version: psm2.4 → Trunk

Updated

9 years ago
Component: Image: Painting → Image: Painting
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.