Closed Bug 392927 Opened 17 years ago Closed 17 years ago

Kill old gfx code in nsIImage

Categories

(Core Graveyard :: Image: Painting, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9alpha8

People

(Reporter: xfsunoles, Assigned: xfsunoles)

Details

Attachments

(1 file, 1 obsolete file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007082005 Minefield/3.0a8pre
Build Identifier: 

Remove all the old, dead gfx code from nsIImage. I had a patch for it. 


Reproducible: Always

Steps to Reproduce:
1.
2.
3.
Attached patch Patch v1.0 (obsolete) — Splinter Review
You should request review from Stuart by going to the "Details" page for the attachment, setting the "review" line to "?", and entering the email "pavlov@pavlov.net" after it.
Attachment #277428 - Flags: review?(pavlov)
Attachment #277428 - Attachment is obsolete: true
Attachment #277428 - Flags: review?(pavlov)
Attached patch Patch v1.1Splinter Review
Attachment #277441 - Flags: review?(pavlov)
Nice.

Some more followup: 
GetIsRowOrderTopToBottom() now always returns PR_TRUE, so we can remove this, and the callers can now always assume TopToBottom (as long as we use Cairo).
Created bug 393001 for this.
Component: GFX → Image: GFX
Assignee: nobody → xfsunoles
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attachment #277441 - Flags: review?(pavlov) → review+
Attachment #277441 - Flags: approval1.9+
Status: NEW → ASSIGNED
Keywords: checkin-needed
mozilla/gfx/public/nsIImage.h  1.30


Please diff from the mozilla/ dir (i.e. cd ~/mozilla;cvs diff -up8 path/to/changed/files > patch). It makes it easier to check patches in.

Also, after editing the patch by hand, please make sure it still applies. Yours gave me "patch unexpectedly ends in middle of line".
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M8
Version: unspecified → psm2.4
Version: psm2.4 → Trunk
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.