If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Extract ab-CD.xpi last when unpacking windows 1.5.0.x installers

RESOLVED FIXED

Status

Release Engineering
General
P2
normal
RESOLVED FIXED
10 years ago
4 years ago

People

(Reporter: nthomas, Assigned: nthomas)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

10 years ago
Created attachment 277537 [details] [diff] [review]
Unpack the locale xpi last

This patch fixes a problem when unpacking 1.5.0.x windows installers, which use a bunch of xpi files. It's the analogue of bug 376878 for older builds.

This patch ensures that locale xpi is extracted last, so that any files used in both the browser and the locale are correctly overwritten with the locale version. It's low tech, in the sense that we just pass the locale thru the various functions and unpack ab-CD.xpi a second time.
Attachment #277537 - Flags: review?(rhelmer)
(Assignee)

Updated

10 years ago
Assignee: build → nrthomas
Priority: -- → P2
Comment on attachment 277537 [details] [diff] [review]
Unpack the locale xpi last

Hmm.. we don't want to unpack the xpis for updates, can you make that optional?

Also shouldn't it be for all OSes?
(Assignee)

Comment 2

10 years ago
This is about "Thunderbird 1.5.0.13 Setup.exe" containing mail.xpi, newsblog.xpi, ...  xpcom.xpi & ab-CD.xpi, which we then unpack to make bin/ for the update verification. It's not related to the talk of unpacking chrome/*.jar for the l10n metadiff.
Comment on attachment 277537 [details] [diff] [review]
Unpack the locale xpi last

Ah ok, this is just for 1.5.x .. I understand then.

>Index: unpack.sh
>===================================================================
>RCS file: /cvsroot/mozilla/testing/release/common/unpack.sh,v
>retrieving revision 1.11
>diff -u -p -5 -r1.11 unpack.sh
>--- unpack.sh	10 Apr 2007 16:32:59 -0000	1.11
>+++ unpack.sh	21 Aug 2007 14:53:17 -0000
>@@ -27,10 +28,11 @@ unpack_build () {
>             else
>               for file in *.xpi
>               do
>                 unzip -o $file > /dev/null
>               done
>+              unzip -o ${locale}.xpi > /dev/null

How does unpacking "*.xpi" not catch "${locale}.xpi"?
(Assignee)

Comment 4

10 years ago
It's an ordering problem. Here's a specific example:

* bg.xpi is unpacked first, creating (amongst other things)
** bin/defaults/pref/all-l10n.js
** bin/README.txt
** bin/updater.ini

* mail.xpi is unpacked later, overwriting those files with en-US versions

* complete update is applied and paves over with locale files

* diff finds stuff because it has bg in source/ and en-US in target/

I hit this when update testing Thunderbird 1.5.0.13 but haven't been able to figure out why it hasn't been a problem before (maybe it has ?). It seems to be all locales that sort alphabetically before mail, and completes updates only. I can't see any changes to the config that would contribute, and it happens on pacifica-vm and tb180-win32-tbox.
Comment on attachment 277537 [details] [diff] [review]
Unpack the locale xpi last

ok, now i understand (finally) :)
Attachment #277537 - Flags: review?(rhelmer) → review+
(Assignee)

Comment 6

10 years ago
Thanks!
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
(Assignee)

Comment 7

10 years ago
I forgot to check for other users of unpack_build when I changed its arguments :-(
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Summary: Extract ab-CD.xpi last when unpacking windows 1.5.0.x installers for update verification → Extract ab-CD.xpi last when unpacking windows 1.5.0.x installers
(Assignee)

Comment 8

10 years ago
Created attachment 292581 [details] [diff] [review]
Fix verify_locales too

Hit this during l10n verify of Tb 1.5.0.14, where the locale wasn't being passed to unpack_build and it would complain that it couldn't unzip ".xpi" (shock!).
Attachment #292581 - Flags: review?(rhelmer)
Attachment #292581 - Flags: review?(rhelmer) → review+
(Assignee)

Comment 9

10 years ago
Checking in l10n/verify_l10n.sh;
/cvsroot/mozilla/testing/release/l10n/verify_l10n.sh,v  <--  verify_l10n.sh
new revision: 1.14; previous revision: 1.13
done
Status: REOPENED → RESOLVED
Last Resolved: 10 years ago10 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.