393084 - Copy series of recurring events to another calendar [clipboard]

Status: RESOLVED FIXED

(Calendar :: General, enhancement)

Description

[juergen.edner]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1.6) Gecko/20070725 Firefox/2.0.0.6
Build Identifier: Thunderbird v2.0.0.6 (20070728) Lightning v0.7pre (2007081804)

I've created a recurring (birthday) event in one ical calendar.
Then I've marked the event and tried to copy it to a second 
ical calendar by pressing CTRL-C, selecting the second calendar
and pressing CTRL-V.
As a result only the marked event has been copied and not the
complete recurring event. It would be much better if the program
would automatically asked which data should be copied, only the
current event or the complete (recurring) event.

Reproducible: Always

Steps to Reproduce:
1.see above description
2.
3.

Comment 2

[Daniel Boelzle [:dbo]]

I'd prefer an additional menu item like "Copy Series" or "Copy All".

Comment 4

[Alexandre Demers]

I know it's been a while since someone look at this bug, but what should happen of exceptions in this case? Should they also be copied or left aside?

Comment 5

[[:MakeMyDay]]

Attachment: CutCopyRepeatingItems-V1.diff

This patch adds the same behaviour as we have it for editing recurring items by presenting the popup to choose to cut/copy the occurence or the entire series.

I considered to implement separate menu options, but this wouldn't be sufficient for keyboard based workflows since Ctrl+C and Ctrl+X are the standard here, which people expect just to work.

Comment 6

[[:MakeMyDay]]

Attachment: CutCopyRepeatingItems-V2.diff

De-bitrotted patch after the recent mass changes. To avoid late string changes, please consider to do the review soon since the patch has string changes.

Comment 7

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 8951993 [details] [diff] [review]
CutCopyRepeatingItems-V2.diff

Review of attachment 8951993 [details] [diff] [review]:
-----------------------------------------------------------------

Just a few minor nits, otherwise this looks fine.

::: calendar/base/content/calendar-item-editing.js
@@ +561,5 @@
>      const MODIFY_PARENT = 3;
>  
> +    let futureItems = false;
> +    let pastItems = [];
> +    let returnItem;

Since returnItem can be returned verbatim if aItem is not passed, maybe it makes sense to explicitly initialize to null?

@@ +588,5 @@
>      switch (type) {
>          case MODIFY_PARENT:
> +            for (let item of items) {
> +                pastItems.push(item.parentItem);
> +            }

pastItems = items.map(item => item.parentItem)

(but I don't have a strong opinion, feel free to keep what you have)

::: calendar/base/content/dialogs/calendar-occurrence-prompt.xul
@@ +46,3 @@
>  
> +          // Set up title and type label
> +          document.title = getDString("windowtitle." + itemType + "." + action);

Maybe use `windowtitle.${itemType}.action` and similar in the other strings?

::: calendar/locales/en-US/chrome/calendar/calendar-occurrence-prompt.properties
@@ +5,5 @@
>  header.isrepeating.event.label=is a repeating event
> +header.isrepeating.task.label=is a repeating task
> +header.containsrepeating.event.label=contain repeating events
> +header.containsrepeating.task.label=contain repeating tasks
> +header.containsrepeating.mixed.label=contain repeating items of different type

contain or contains?

@@ +24,2 @@
>  
> +buttons.single.occurrence.copy.label=Copy just this occurrence

I don't have a strong feeling here, but s/just/only/ sounds better in my ears.

Comment 8

[[:MakeMyDay]]

Attachment: CutCopyRepeatingItems-V3.diff

Thanks, updated patch with comments considered.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6bb845d0c8fc
Allow to cut/copy the series or a single occurrence for repeating items. r=philipp

Comment 10

[Ton [:Tonnes]]

> +buttons.multiple.allfollowing.edit.label=Edit selcted and all future occurrences
> +
> +
> +buttons.multiple.parent.copy.label=Copy all occurrences of selceted items
> +buttons.multiple.parent.cut.label=Cut all occurrences of selceted items

MakeMyDay: can you check for and fix the typos?

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e0290580088a
fix typos in "selected". rs=typo-fix DONTBUILD

Comment 12

[Jorg K (CEST = GMT+2)]

Thnask, Ton :-)
(Seriously, much appreciated that you advise of spelling mistakes!)

Comment 13

[[:MakeMyDay]]

Attachment: FixStringCompositionRegression-V1.diff

I didn't craft the string composition properly in the landed patch, the attached one takes care to fix this.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3c9b650ac751
Fix string composition regression. r=philipp