393115 - Improve Wording and Minor Style Cleanup for the Msg Notification Bar

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Scott MacGregor]

I'd like to improve the wording we use for the msg notification bar. The text for phishing, remote images, and junk are overly wordy and I think will benefit from more concise text.

I'm also making a few style changes while I'm here.

Comment 1

[Scott MacGregor]

Attachment: screen shot with the proposed changes

Screen shot showing the new text for each notification. I thought about adding an explanation point to the Suspected Email Scam! text, not sure if that's too much or not. 

Patch coming up.

Comment 2

[Scott MacGregor]

Attachment: the fix

What do you think of this Phil.

* String changes to the notifcations as shown in the screen shot
* uses .value instead of .textContent because .textContent was causing the link text to not be underlined. 
* I changed the string ids for most of the strings because I wanted localizers to update their translations to use these shorter strings.
* I didn't change the id for this change:
-<!ENTITY reportPhishingURL.label "Report E-mail Scam">
+<!ENTITY reportPhishingURL.label "Report Email Scam">
because I considered this a typo in the english translation. We don't hyphenate email.

* The phishing notification bar is going to eventually support the ability to report false positives. I've added a text link for this and right now it's collapsed. I wanted to get the string in the tree for localizers to translate since they'll be in the vicinity anyway making the rest of these changes.

Comment 3

[Scott MacGregor]

Attachment: try to attach the patch again...

is this one any better Phil? Fresh patch against my tree.

Comment 4

[Phil Ringnalda (:philor)]

Comment on attachment 278190 [details] [diff] [review]
try to attach the patch again...

No idea what's up with my build problem, since all the changes seem to be jarred up, it just won't run until I clobber after applying the patch. So if any of the tinderboxes are unhappy when you check in, you'll know what to do.

r=me, but rather than going from foo.label to foo1.label, I'd prefer to jump to foo2.label - I'm pretty sure I'm not the only one with default fonts that don't do enough to distinguish 1 from l, and I kept wondering "what's a MESSAGEL?" (Axel, of course, thinks you should change to something like junkBarMessageWithShorterLabelThanBefore.label, but I don't see a reasonable way to make the label express the semantics of the change when the change is only relative to what it was before.)

Comment 5

[Scott MacGregor]

I landed this patch but for some reason never marked this as fixed.