393119 - XPConnect's Dump doesn't do string conversions correctly

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Dan Mills [:thunder]]

Attachment: XPConnect Dump patch

It breaks on UTF-16 strings, because it gets bytes instead of chars, and just prints them directly.

The attached patch solves the problem.

Test case:

I have an ini file like:

[foo]
cheese=チーズが好きですか。

And some code like this (iniFile is an nsILocalFile):

var ini = Cc["@mozilla.org/xpcom/ini-parser-factory;1"].
  getService(Ci.nsIINIParserFactory).createINIParser(iniFile);
var cheese = ini.getString("foo", "cheese");
dump(cheese + "\n");

And I see garbage on the terminal (using OS X's Terminal.app).

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I think we want to make XPConnect's dump assume the console is UTF-8 (that is, take this patch) since:

 1) it matches what window.dump does in chrome, and it's confusing to have those behave differently.

 2) I think most modern consoles are UTF-8 (Mac OS X, most modern Linux distros), and if they're not, you're probably not going to be able to usefully print most non-ASCII stuff anyway.

You should request r+sr from jst, I think.

Comment 2

[Dan Mills [:thunder]]

This bug just hit mhanson.  I no longer have a mozilla tree set up, if any of you wouldn't mind checking that the patch still applies and commit it, I'll owe you a hug.  Or a beer.  Up to you.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Updated to trunk

The patch didn't apply... so I updated it.

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

The tree is metered right now so I can't check in. But hopefully someone will come along and check the updated patch in.

Comment 5

[Dan Mills [:thunder]]

Yay! Hugs for mrbkap!

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

http://hg.mozilla.org/mozilla-central/rev/3a91d9ba7f22

Comment 7

[Jacek Caban]

Attachment: mingw fix

This patch broke mingw compilation where wchar_t != unsigned short. The attached patch fixes the problem.

Comment 8

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 435135 [details] [diff] [review]
mingw fix

Ick.

Comment 9

[Blake Kaplan (:mrbkap) (inactive)]

Reopening... I'm not sure if our checkin-needed fairies check FIXED bugs.

Comment 10

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/mozilla-central/rev/7019e5fc3ede