393124 - nsINavBookmarkObserver's onItemVisit called too many times

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect, P3)

Description

[u278084]

When I visit a website that I have bookmarked and tagged, the nsINavBookmarkObserver's onItemVisit() method gets called once for the visit, and then once again for each tag. So if I there are two tags, the observer gets called 3 times.

Don't know if this is a bug, or if I am doing this wrong. So setting it as unconfirmed.

Comment 1

[u278084]

Attachment: testcase

Here are the steps to reproduce. Do this using trunk build or a nightly :
1. Visit http://example.com/
2. Bookmark the site and tag it as foo and bar
3. Open up the html file attached, and accept the extended js privileges
4. Open up a new tab and visit http://example.com/
5. Wait about a second or two

Actual Results :
Many alert boxes telling you that you are visiting a bookmarked page

Expected Results :
A single alert box telling you that you are visiting a bookmarked site

Comment 2

[Dietrich Ayala (:dietrich)]

this occurs because tags are stored in the bookmarks system, and internally to the service each tagged uri appears as a bookmark.

Comment 3

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv

Comment 4

[Marco Bonardo [:mak]]

This should be fixed, we filter tags before notifying now.