393125 - Remove manual QI calls etc from plugin code.

Status: RESOLVED INVALID

(Core Graveyard :: Plug-ins, defect)

Description

[Johnny Stenback (:jst)]

Attachment: Clean up a bunch of oh-so-1999 code :)

Found this looking through some code...

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 277634 [details] [diff] [review]
Clean up a bunch of oh-so-1999 code :)

+  // Uh, what's the point of this?
   aOwner->GetInstance(mInstance);
   NS_IF_RELEASE(mInstance);


Cute...

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Initialize has the same seemingly useless code. looks like mInstance is entirely unused?

At a guess, from the comment in the .h file I would say they wanted to keep a weak reference but missed the fact that NS_IF_RELEASE nulls out the pointer. (and the comment about mOwner is a lie *sigh*)

Comment 3

[Johnny Stenback (:jst)]

Attachment: More cleanup.

Indeed. I removed mInstance entirely, and made mOwner an nsCOMPtr. Also nuked kIOutputStreamIID.

Comment 4

[Johnny Stenback (:jst)]

The patch here is obsolete by now due to a ton of other cleanup that's been done by now. Marking INVALID.