393181 - Memory leaks in ocspclnt in calls to CERT_SetOCSPDefaultResponder

Status: RESOLVED DUPLICATE of bug 403888

(NSS :: Libraries, defect, P2)

Description

[Slavomir Katuscak]

Found some memory leaks in CERT_SetOCSPDefaultResponder:

Memory Leak (mel):
Found leaked block of size 38 bytes at address 0x5f7bc0
At time of allocation, the call stack was:
    [1] PR_Malloc() at line 467 in "prmem.c"
    [2] PORT_Alloc() at line 113 in "secport.c"
    [3] PORT_Strdup() at line 171 in "secport.c"
    [4] CERT_SetOCSPDefaultResponder() at line 5063 in "ocsp.c"
    [5] main() at line 1212 in "ocspclnt.c"

Memory Leak (mel):
Found leaked block of size 25 bytes at address 0x6058f0
At time of allocation, the call stack was:
    [1] PR_Malloc() at line 467 in "prmem.c"
    [2] PORT_Alloc() at line 113 in "secport.c"
    [3] PORT_Strdup() at line 171 in "secport.c"
    [4] CERT_SetOCSPDefaultResponder() at line 5064 in "ocsp.c"
    [5] main() at line 1212 in "ocspclnt.c"

Memory Leak (mel):
Found leaked block of size 16 bytes at address 0x5fbd88
At time of allocation, the call stack was:
    [1] calloc() at 0xe0954ab4
    [2] PR_Calloc() at line 475 in "prmem.c"
    [3] PORT_ZAlloc() at line 140 in "secport.c"
    [4] ocsp_InitStatusChecking() at line 4939 in "ocsp.c"
    [5] CERT_SetOCSPDefaultResponder() at line 5076 in "ocsp.c"
    [6] main() at line 1212 in "ocspclnt.c"

Memory Leak (mel):
Found leaked block of size 12 bytes at address 0x5fbe78
At time of allocation, the call stack was:
    [1] calloc() at 0xe0954ab4
    [2] PR_Calloc() at line 475 in "prmem.c"
    [3] PORT_ZAlloc() at line 140 in "secport.c"
    [4] ocsp_InitStatusChecking() at line 4935 in "ocsp.c"
    [5] CERT_SetOCSPDefaultResponder() at line 5076 in "ocsp.c"
    [6] main() at line 1212 in "ocspclnt.c"

What is allocated and not freed:

CERT_SetOCSPDefaultResponder
   5063     url_copy = PORT_Strdup(url);
   5064     name_copy = PORT_Strdup(name);

ocsp_InitStatusChecking (called directly from CERT_SetOCSPDefaultResponder):
   4935     statusConfig = PORT_ZNew(CERTStatusConfig);
   4939     statusContext = PORT_ZNew(ocspCheckingContext);

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Slavo, we need to know what programs called CERT_SetOCSPDefaultResponder()
That information is not in the stacks above.

Comment 2

[Slavomir Katuscak]

It's from ocspclnt. You can see it also in every stack on the last line - file which contains main().

[5] main() at line 1212 in "ocspclnt.c" --> ocspclnt

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

If this is merely a leak in the ocsp test program, then it is only P3,
but if it is a leak in the library, then it is P2 for 3.12. 
For now, I'm marking it assuming that it is a library leak.

Comment 4

[Nelson Bolyard (seldom reads bugmail)]

Assigning OCSP bugs to Mr. OCSP. :)

Comment 5

[Slavomir Katuscak]

After adding OCSP tests to branch bug found also there.

Comment 6

[Julien Pierre]

I think is a dupe of 403888 , although the leak was triggered by CERT_EnableOCSPChecking in that bug. The fix was checked in on the trunk. I checked the trunk tinderbox, and there is no longer a leak in CERT_SetOCSPDefaultResponder , whereas the branch tinderbox still reports it in the ignored stacks list. So, I will mark this as a dupe of 403888 and retarget it to 3.11.10 .

Comment 7

[Slavomir Katuscak]

As this is duplicate of 403888 which is already fixed, I'm removing this bug from list of ignored leaks.