make PerfConfigurator.py support linux and mac

RESOLVED FIXED

Status

Release Engineering
General
P2
normal
RESOLVED FIXED
11 years ago
5 years ago

People

(Reporter: bhearsum, Assigned: bhearsum)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: ready for checkin)

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

11 years ago
Right now PerfConfigurator.py only runs on Windows. It needs to run on Linux and Mac, too.

I'll be posting a patch that does this in the next day or so. It will also include some bugfixes and cleanup.
(Assignee)

Updated

11 years ago
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: eta: august 23
(Assignee)

Comment 1

11 years ago
Looks like this is working well. I still need to test it a bit more on Mac, but I don't expect any problems.
Whiteboard: eta: august 23 → eta: august 27
(Assignee)

Comment 2

11 years ago
Created attachment 278430 [details]
PerfConfigurator with linux/mac support

This version of PerfConfigurator runs cleanly on Mac and Linux. The only thing that needs to be adjusted is the masterIniSubpath, if the BuildID is to be autodetected.
Attachment #278430 - Flags: review?(rcampbell)
(Assignee)

Comment 3

11 years ago
Forgot to mention that this version probably supersedes that in bug#393266
Comment on attachment 278430 [details]
PerfConfigurator with linux/mac support

you should write this against the latest version of PerfConfigurator.py checked in to tools/buildbot-configs/testing/talos last week. It includes some of the bugfixes you have here.
Attachment #278430 - Flags: review?(rcampbell) → review-
(Assignee)

Comment 5

11 years ago
Created attachment 278636 [details] [diff] [review]
multiplatform configurator

Here ya go, in patch form. This version supports Talos 1. I've got a version that supports Talos 2 that I can throw up once that gets checked in.
Attachment #278430 - Attachment is obsolete: true
Attachment #278636 - Flags: review?(rcampbell)
Comment on attachment 278636 [details] [diff] [review]
multiplatform configurator

This looks good. At some point we'll want to rip out the _getBuildId() function in favor of something that doesn't rely on talkback but that's what we've got for now. We'll also have to update the version in the talos directory as well (or just move it there so we don't have to keep copying this around).
Attachment #278636 - Flags: review?(rcampbell) → review+
(Assignee)

Comment 7

11 years ago
Can we get this checked in?
Whiteboard: eta: august 27 → ready for checkin
Checked into tools/buildbot-configs/testing/talos/perfmaster and testing/performance/talos

cvs commit: Examining .
Checking in PerfConfigurator.py;
/cvsroot/mozilla/tools/buildbot-configs/testing/talos/perfmaster/PerfConfigurator.py,v  <--  PerfConfigurator.py
new revision: 1.3; previous revision: 1.2
done

cvsci "bug 393252 - make PerfConfigurator.py support linux and mac, patch by bhearsum@mozilla.com, r=robcee"
cvs commit: Examining .
cvs commit: Examining base_profile
cvs commit: Examining base_profile/Cache
cvs commit: Examining base_profile/bookmarkbackups
cvs commit: Examining page_load_test
cvs commit: Examining startup_test
Checking in PerfConfigurator.py;
/cvsroot/mozilla/testing/performance/talos/PerfConfigurator.py,v  <--  PerfConfigurator.py
new revision: 1.2; previous revision: 1.1
done
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Mass move of Core:Testing bugs to mozilla.org:Release Engineering:Talos. Filter on RelEngTalosMassMove to ignore.
Component: Testing → Release Engineering: Talos
Product: Core → mozilla.org
QA Contact: testing → release
Version: unspecified → other

Updated

9 years ago
Component: Release Engineering: Talos → Release Engineering
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.