make langpack-% should ensure dist/install

VERIFIED FIXED

Status

()

VERIFIED FIXED
11 years ago
11 years ago

People

(Reporter: Pike, Unassigned)

Tracking

({verified1.8.1.8})

2.0 Branch
verified1.8.1.8
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

11 years ago
Created attachment 277762 [details] [diff] [review]
nsinstall dist/install for langpack-%

browser is the only one of our toolkit apps that actually doesn't create the dist/install directory if you create just a langpack.

Let's fix that. As Benjamin is out this week, trying to get simple review from rhelmer instead.
Attachment #277762 - Flags: review?(rhelmer)
Attachment #277762 - Flags: review?(rhelmer) → review+
(Reporter)

Updated

11 years ago
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
(Reporter)

Comment 1

11 years ago
Comment on attachment 277762 [details] [diff] [review]
nsinstall dist/install for langpack-%

Fixed on trunk. I'd want this on the branch, too, to make l10n easier and more agile for folks working on 2.0.0.x still.

No impact outside of the langpack world, existing l10n repackaging logic is untouched. This is in production in a similar fashion for Thunderbird, too.
Attachment #277762 - Flags: approval1.8.1.7?
Comment on attachment 277762 [details] [diff] [review]
nsinstall dist/install for langpack-%

approved for 1.8.1.7, a=dveditz for release-drivers
Attachment #277762 - Flags: approval1.8.1.7? → approval1.8.1.7+
(Reporter)

Comment 3

11 years ago
Landed on branch.
Keywords: fixed1.8.1.7
Is there a way to verify this on the 1.8 branch?
(Reporter)

Comment 5

11 years ago
Yes, I verified that locally. For reference, just create a language pack from the 1.8 branch, if 

make langpack-de

in a firefox-configured build dir browser/locales works, it works :-)
Status: RESOLVED → VERIFIED
Keywords: fixed1.8.1.8 → verified1.8.1.8
I haven't really looked into l10 building (yet).
Thanks for verifying (and explaining).
You need to log in before you can comment on or make changes to this bug.