393261 - make langpack-% should ensure dist/install

Status: VERIFIED FIXED

(Firefox Build System :: General, defect)

Description

[Axel Hecht [:Pike]]

Attachment: nsinstall dist/install for langpack-%

browser is the only one of our toolkit apps that actually doesn't create the dist/install directory if you create just a langpack.

Let's fix that. As Benjamin is out this week, trying to get simple review from rhelmer instead.

Comment 1

[Axel Hecht [:Pike]]

Comment on attachment 277762 [details] [diff] [review]
nsinstall dist/install for langpack-%

Fixed on trunk. I'd want this on the branch, too, to make l10n easier and more agile for folks working on 2.0.0.x still.

No impact outside of the langpack world, existing l10n repackaging logic is untouched. This is in production in a similar fashion for Thunderbird, too.

Comment 2

[Daniel Veditz [:dveditz]]

Comment on attachment 277762 [details] [diff] [review]
nsinstall dist/install for langpack-%

approved for 1.8.1.7, a=dveditz for release-drivers

Comment 3

[Axel Hecht [:Pike]]

Landed on branch.

Comment 4

[Martijn Wargers (dead)]

Is there a way to verify this on the 1.8 branch?

Comment 5

[Axel Hecht [:Pike]]

Yes, I verified that locally. For reference, just create a language pack from the 1.8 branch, if 

make langpack-de

in a firefox-configured build dir browser/locales works, it works :-)

Comment 6

[Martijn Wargers (dead)]

I haven't really looked into l10 building (yet).
Thanks for verifying (and explaining).