393270 - Windows dependency generation only works for files in $(srcdir)

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[[e-mail]]

Since mkdepend.exe only works on Windows paths, we can't use the $(<D) trick to remove the path name from the .obj file in the .pp file. Currently we use $(srcdir) but that doesn't work for nsMIMEInfoWin.cpp for example.

Comment 1

[[e-mail]]

Attachment: Option 1 - just chop all paths off

This assumes that paths don't contain spaces, which I think is correct, no?

Comment 2

[[e-mail]]

Attachment: Option 2 - just tweak the srcdir regexp slightly

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 277769 [details] [diff] [review]
Option 2 - just tweak the srcdir regexp slightly

r=me on this, but I do like the other patch, I'd just prefer to have bsmedberg take a look at it.

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 277767 [details] [diff] [review]
Option 1 - just chop all paths off

bsmedberg: is there anything conceptually wrong with this patch?  It's a nice cleanup if we do intend to strip all paths from the obj files in the depends file.

Comment 5

[[e-mail]]

So, for anyone still interested, we ran with the second patch for a bit, but I've now backed that out and checked in the first patch instead.