Closed Bug 393301 Opened 16 years ago Closed 16 years ago

Add UI for downloads in scanning state

Categories

(Toolkit :: Downloads API, defect)

Product:
Toolkit
Component:
Downloads API
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.9beta1

People

(Reporter: robarnold, Assigned: sdwilsh)

References

Details

Attachments

(1 file, 2 obsolete files)

v1.2
5.05 KB, patch
mconnor
: approval1.9+
Details | Diff | Splinter Review
Blocks: 103487
No longer depends on: 103487
Attached patch v1.0 (obsolete) — — Splinter Review 
This is the string that faaborg suggested on irc.
Assignee: nobody → comrade693+bmo
Status: NEW → ASSIGNED
Attachment #277837 - Flags: review?(gavin.sharp)
Flags: blocking-firefox3?
Target Milestone: --- → Firefox 3 M8
Any thought to a progress bar for this state? F/U bug?
Or isn't this even feasible?
(In reply to comment #2)
> Any thought to a progress bar for this state? F/U bug?
> Or isn't this even feasible?
Not possible with the API Microsoft gives us.


This looks fine, but I get an exception when I try to right click a download item in this state:

Error: menus has no properties
Source File: chrome://mozapps/content/downloads/downloads.js
Line: 457
Hardware: PC → All
Attached patch v1.1 (obsolete) — — Splinter Review 
Fixes error.
Attachment #277837 - Attachment is obsolete: true
Attachment #280253 - Flags: review?(gavin.sharp)
Attachment #277837 - Flags: review?(gavin.sharp)
Comment on attachment 280253 [details] [diff] [review]
v1.1

r=me, but you forgot to include the toolkit/locales part in this patch.
Attachment #280253 - Flags: review?(gavin.sharp) → review+
Attached patch v1.2 — — Splinter Review 
for checkin
Attachment #280253 - Attachment is obsolete: true
Keywords: checkin-needed
Target Milestone: Firefox 3 M8 → Firefox 3 M9
Attachment #280351 - Flags: approval1.9? → approval1.9+
Checking in toolkit/locales/en-US/chrome/mozapps/downloads/downloads.dtd;
new revision: 1.11; previous revision: 1.10
Checking in toolkit/mozapps/downloads/content/download.xml;
new revision: 1.36; previous revision: 1.35
Checking in toolkit/mozapps/downloads/content/downloads.css;
new revision: 1.11; previous revision: 1.10
Checking in toolkit/mozapps/downloads/content/downloads.js;
new revision: 1.88; previous revision: 1.87
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: blocking-firefox3?
Keywords: checkin-needed
Resolution: --- → FIXED
No longer blocks: 372972
Verified FIXED; http://img171.imageshack.us/my.php?image=picture1kw9.png

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a9pre) Gecko/2007101704 Minefield/3.0a9pre
Status: RESOLVED → VERIFIED
Depends on: 402985
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.