Add UI for downloads in scanning state

VERIFIED FIXED in mozilla1.9beta1

Status

()

Toolkit
Downloads API
VERIFIED FIXED
10 years ago
9 years ago

People

(Reporter: robarnold, Assigned: sdwilsh)

Tracking

Trunk
mozilla1.9beta1
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

10 years ago
 
Blocks: 103487
No longer depends on: 103487
(Assignee)

Comment 1

10 years ago
Created attachment 277837 [details] [diff] [review]
v1.0

This is the string that faaborg suggested on irc.
Assignee: nobody → comrade693+bmo
Status: NEW → ASSIGNED
Attachment #277837 - Flags: review?(gavin.sharp)
(Assignee)

Updated

10 years ago
Flags: blocking-firefox3?
Target Milestone: --- → Firefox 3 M8

Comment 2

10 years ago
Any thought to a progress bar for this state? F/U bug?
Or isn't this even feasible?
(Assignee)

Comment 3

10 years ago
(In reply to comment #2)
> Any thought to a progress bar for this state? F/U bug?
> Or isn't this even feasible?
Not possible with the API Microsoft gives us.

This looks fine, but I get an exception when I try to right click a download item in this state:

Error: menus has no properties
Source File: chrome://mozapps/content/downloads/downloads.js
Line: 457
Hardware: PC → All
(Assignee)

Comment 5

10 years ago
Created attachment 280253 [details] [diff] [review]
v1.1

Fixes error.
Attachment #277837 - Attachment is obsolete: true
Attachment #280253 - Flags: review?(gavin.sharp)
Attachment #277837 - Flags: review?(gavin.sharp)
Comment on attachment 280253 [details] [diff] [review]
v1.1

r=me, but you forgot to include the toolkit/locales part in this patch.
Attachment #280253 - Flags: review?(gavin.sharp) → review+
(Assignee)

Comment 7

10 years ago
Created attachment 280351 [details] [diff] [review]
v1.2

for checkin
Attachment #280253 - Attachment is obsolete: true
(Assignee)

Updated

10 years ago
Keywords: checkin-needed
Attachment #280351 - Flags: approval1.9?
Keywords: checkin-needed
(Assignee)

Updated

10 years ago
Target Milestone: Firefox 3 M8 → Firefox 3 M9

Updated

10 years ago
Attachment #280351 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
(Assignee)

Comment 8

10 years ago
Checking in toolkit/locales/en-US/chrome/mozapps/downloads/downloads.dtd;
new revision: 1.11; previous revision: 1.10
Checking in toolkit/mozapps/downloads/content/download.xml;
new revision: 1.36; previous revision: 1.35
Checking in toolkit/mozapps/downloads/content/downloads.css;
new revision: 1.11; previous revision: 1.10
Checking in toolkit/mozapps/downloads/content/downloads.js;
new revision: 1.88; previous revision: 1.87
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Flags: blocking-firefox3?
Keywords: checkin-needed
Resolution: --- → FIXED

Updated

10 years ago
No longer blocks: 372972
Verified FIXED; http://img171.imageshack.us/my.php?image=picture1kw9.png

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a9pre) Gecko/2007101704 Minefield/3.0a9pre
Status: RESOLVED → VERIFIED

Updated

10 years ago
Depends on: 402985
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.