393401 - allow cross-site XMLHttpRequest for tinderbox JSON output

Status: RESOLVED FIXED

(Webtools Graveyard :: Tinderbox, defect)

Description

[(not currently active) Ted Mielczarek]

Attachment: add Content-Access-Control header to JSON output

bug 389508 implemented cross-site XMLHttpRequest on trunk, we should allow this for the tinderbox JSON output, which would mean that people could build their own waterfall displays on any random webpage.

I believe all we have to send is:
Content-Access-Control: allow <*>

per
http://www.w3.org/TR/access-control/#content-access-control

Patch is attached, I haven't tested it since I don't really want to setup a tinderbox server.

Comment 1

[Reed Loden [:reed]]

(In reply to comment #0)
> I haven't tested it since I don't really want to setup a
> tinderbox server.

You know you want to set one up yourself! :)

Comment 2

[Mike Taylor [:bear]]

Checking in showbuilds.pl;
/cvsroot/mozilla/webtools/tinderbox/showbuilds.pl,v  <--  showbuilds.pl
new revision: 1.25; previous revision: 1.24
done

Comment 3

[Justin Dolske [:Dolske]]

It would appear the spec has changed since this was fixed. The new header should be:

Access-Control-Allow-Origin: *

(I think, from looking at the spec. Didn't test.)

Comment 4

[Justin Dolske [:Dolske]]

Attachment: Patch v.2

Updates the header the original patch added, to match the current XS-XHR spec. Untested, but obvious enough.

Comment 5

[Reed Loden [:reed]]

Comment on attachment 358771 [details] [diff] [review]
Patch v.2

>+        print "Access-Control-Allow-Origin: *\n\n";

"*", no?

Also, this needs adding to INSTALL, too (it's currently in tinderbox's vhost but not documented anywhere).

Comment 6

[Justin Dolske [:Dolske]]

(In reply to comment #5)

> "*", no?

No.
 
> Also, this needs adding to INSTALL, too (it's currently in tinderbox's vhost
> but not documented anywhere).

I'm only fixing the original patch. I'm not going to document Tinderbox.

Comment 7

[Robert Helmer [:rhelmer]]

Comment on attachment 358771 [details] [diff] [review]
Patch v.2

Why wasn't this landed? Cross-site XHR isn't working and we need it for bug 586123.

What is the documentation issue?

Comment 8

[Robert Helmer [:rhelmer]]

Attachment: set Access-Control-Allow-Origin for json and json2

Set Access-Control-Allow-Origin for both json and json2.

Comment 9

[Mike Taylor [:bear]]

Comment on attachment 465701 [details] [diff] [review]
set Access-Control-Allow-Origin for json and json2

The example given in the INSTALL document should be updated to reflect this change

Comment 10

[Mike Taylor [:bear]]

Comment on attachment 465701 [details] [diff] [review]
set Access-Control-Allow-Origin for json and json2

bah - I need to get my glasses fixed ;)  The INSTALL doc already has it listed I just can't read

Comment 11

[Robert Helmer [:rhelmer]]

Checking in showbuilds.pl;
/cvsroot/mozilla/webtools/tinderbox/showbuilds.pl,v  <--  showbuilds.pl
new revision: 1.43; previous revision: 1.42
done