393451 - getBoundingClientRects with submenus

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Neil Deakin]

Attachment: testcase

getBoundingClientRects on a popup returns a rectangle of the popup relative to the document origin, yet a submenu returns incorrect values.

In this testcase:

1. Click the button to open a menu
2. Open the submenu for item 'Three'
3. Close the menus. The positions of the menus will appear below the button. The outer values look ok, but the values for the inner menu are odd.

The 'top' value looks correct, but 'left' has the same value as the parent menu even though it appears to the right. Also, the 'right' and 'bottom' are the same as 'left' and 'top' making it appear as if the popup has a zero size.

Comment 1

[Marco Bonardo [:mak] (Away July 4-13)]

Attachment: testcase 2, wrong top in submenu

also see the subinner top here, when the menu goes out of screen and is bounced up... it is totally wrong, this makes comparation of menu items with event.clientY a pain

Comment 2

[Neil Deakin]

Attachment: let's try this fix

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

+  for (;refFrame && !refFrame->IsFrameOfType(nsIFrame::eSVGForeignObject);
+        refFrame = refFrame->GetParent());

How about stopping when !refFrame->GetParent()? Then you don't need the call to GetRootFrame.

Why do we need to change the boxObject here? I'd rather leave it alone for compatibility and encourage XUL users to use getBoundingClientRect instead.

Comment 4

[Neil Deakin]

Attachment: just change client rects

Comment 5

[Martijn Wargers (dead)]

https://bugzilla.mozilla.org/attachment.cgi?id=295931 was checked in at 2008-01-10 07:48, right?
So this bug can be marked fixed then?