39346 - GetOffsetFromWidget() doesn't return correct offset

Status: VERIFIED INVALID

(Core :: Web Painting, defect, P3)

Description

[Mike Pinkerton (not reading bugmail)]

There seems to be a big problem with GetOffsetFromWidget() that we are running 
into in the mac d&d code for mailnews.

The problem is that in mailnews, the tree is a child view of a view that actually 
has a widget, and the tree's view is not at 0,0 with respect to its parent.

When the code enters GetOffsetFromWidget(), it first goes to the parent and asks 
if it has a widget (it does), so it just returns, never setting the out 
parameters with the correct offsets. I tried changing it so that it starts at the 
child view before asking the parent, but that causes other problems elsewhere.

Am I missing something here?

Comment 1

[Mike Pinkerton (not reading bugmail)]

nominating for beta2. d&d in mailnews for mac is not very usable until this is 
fixed.

Comment 2

[Kevin McCluskey (gone)]

The GetOffsetFromWidget method should be renamed to GetParentOffsetFromWidget. 
That is how it is implemented and used.

In NS_IMETHODIMP nsView :: SynchWidgetSizePosition() there is some code which 
calls GetOffsetFromWidget then adds in the nsView's mBounds to get the full 
offset for the view instance.

   GetOffsetFromWidget(&parx, &pary, pwidget);
      NS_IF_RELEASE(pwidget);

      PRInt32 x = NSTwipsToIntPixels(mBounds.x + parx, t2p);
      PRInt32 y = NSTwipsToIntPixels(mBounds.y + pary, t2p);

Pink: If you do that for the d&d code does it solve the problem?

Comment 3

[Mike Pinkerton (not reading bugmail)]

thanks kevin. my bad.

Comment 4

[Chris Petersen]

Marking verified invalid.