393472 - EXPIRE_NEVER annos can be orphaned when moz_places records are deleted

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[(not reading, please use [e-mail] instead)]

EXPIRE_NEVER annos can be orphaned when moz_places records are deleted

spun off of bug #393223

dietrich has a patch

Comment 1

[Dietrich Ayala (:dietrich)]

Attachment: fix

Comment 2

[(not reading, please use [e-mail] instead)]

Comment on attachment 277971 [details] [diff] [review]
fix

two questions:

1)  a.expires, shouldn't that be a.expiration?  I would think that with your change ExpireHistoryParanoid() is going to fail.  (does your test case test it?)

2)

"LEFT JOIN moz_annos a ON h.id = a.place_id "

could just be:

"JOIN moz_annos a ON h.id = a.place_id "

Comment 3

[Dietrich Ayala (:dietrich)]

Attachment: fix v2

ok, those are corrected. there was a lot of error-swallowing in that code due to the need to not block shutdown activity, etc, and it was masking these problems. i've added warnings for each instance so that failures for these methods will be visible from now on.

Comment 4

[(not reading, please use [e-mail] instead)]

Comment on attachment 278071 [details] [diff] [review]
fix v2

r=sspitzer, thanks dietrich!

note, it looks like you've included Marco's patch for bug #387573

Comment 5

[Dietrich Ayala (:dietrich)]

Checking in toolkit/components/places/src/nsNavHistoryExpire.cpp;
/cvsroot/mozilla/toolkit/components/places/src/nsNavHistoryExpire.cpp,v  <--  nsNavHistoryExpire.cpp
new revision: 1.15; previous revision: 1.14
done
Checking in toolkit/components/places/tests/unit/test_expiration.js;
/cvsroot/mozilla/toolkit/components/places/tests/unit/test_expiration.js,v  <--  test_expiration.js
new revision: 1.6; previous revision: 1.5
done

Comment 6

[Dietrich Ayala (:dietrich)]

Verified: no longer able to expire records tied to EXPIRE_NEVER annotations.

Comment 7

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv