393515 - LSFileQuarantine support

Status: RESOLVED FIXED

(Camino Graveyard :: Downloading, defect)

Description

[Stuart Morgan]

Attachment: basic support

Basic support for LSFileQuarantine.

Comment 1

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 278008 [details] [diff] [review]
basic support

rs=pink

Comment 2

[Stuart Morgan]

Landed on trunk and MOZILLA_1_8_BRANCH.

Comment 3

[Steven Michaud [:smichaud] (Retired)]

This stuff is Leopard-specific, right?

Now that it's about to come out, are you willing to let on what it's
supposed to do? :-)

I'm wondering if it might help with bug 400227 ... though so far my
tests indicate the answer is "no".

Comment 4

[Stuart Morgan]

This opted us in to the quarantine system (the thing that pops up the "You download this from the internet, are you sure you want to open it" dialog) in a way that let us control the quarantine behavior on things we created but were not downloads (e.g., the profile).

Comment 5

[Stuart Morgan]

... but this reminds me, I need to file a follow-up bug about having core support the part of the quarantine system that lets the dialog say where the file was downloaded from.

Comment 6

[Steven Michaud [:smichaud] (Retired)]

Thanks, Stuart.  So my guess was right.

But I can't get the Info.plist syntax from this bug working in
Firefox.  I suspect that Apple has simply not (yet) implemented the
LSFileQuarantine "exclusions" ... at least not as of build 9A559 (one
release before the gold master, which is build 9A581).

Have you been able to devise a test to see if Camino's "exclusions"
are working?

Comment 7

[Steven Michaud [:smichaud] (Retired)]

I've found out why this bug's patch's syntax doesn't work in Firefox
(at least as of Leopard client build 9A559):  You may only specify one
exclusion.  If you specify more than one (as this bug's patch does),
neither will work.  For more info see bug 400227 comment #24.

Comment 8

[Stuart Morgan]

The follow up bug I alluded to is now bug 401748. Quick tests suggest Camino's exclusion isn't working, but I haven't dug into it to be sure I'm not just doing the test incorrectly.

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Reopening because this isn't working right all the time, per our investigations.

Comment 10

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Is this worth landing as-is for 1.5.4 when it appears not to be working?

Comment 11

[Stuart Morgan]

I landed a modification that uses the same thing Firefox uses (~/Library/*) which is working in my testing, so if we want that version for 1.5.x we can take that.

Comment 12

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on the CAMINO_1_5_BRANCH for 1.5.4 with the new syntax.

Comment 13

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: CAMINO_1_5_BRANCH patch

Here's the 1_5 patch as checked-in.