"Restart Thunderbird" button is too small, text doesn't fit

RESOLVED FIXED

Status

()

Toolkit
Crash Reporting
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Martijn Wargers (dead), Assigned: ted)

Tracking

Trunk
Points:
---
Bug Flags:
in-litmus ?

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

10 years ago
When I crash in Thunderbird, the breakpad reporter comes up nicely, but the "Restart Thunderbirtd" button is too small for that text.

Maybe you need to keep this in mind regarding bug 358079?
Other languages might have even longer words.
(Assignee)

Comment 1

10 years ago
campd: can we make this auto-size properly?
(Assignee)

Updated

10 years ago
Duplicate of this bug: 396639
Duplicate of this bug: 397784
(Assignee)

Comment 4

10 years ago
Created attachment 287584 [details] [diff] [review]
os x patch

One platform down.
Assignee: nobody → ted.mielczarek
Status: NEW → ASSIGNED
(Assignee)

Comment 5

10 years ago
Created attachment 287596 [details] [diff] [review]
win32 patch

Realized as I was creating this patch that we'll probably need to resize the "View Report" button as well.
(Assignee)

Comment 6

10 years ago
Created attachment 287598 [details] [diff] [review]
win32 patch

Easy enough.  The OS X patch doesn't need this bit, because it uses a label there, not a button.
Attachment #287596 - Attachment is obsolete: true
(Assignee)

Comment 7

10 years ago
Comment on attachment 287584 [details] [diff] [review]
os x patch

This isn't actually a problem on Linux.  Dave, can you take a look at these two patches?
Attachment #287584 - Flags: review?(dcamp)
(Assignee)

Comment 8

10 years ago
Not really All/All, but 2/3 is close enough.
OS: Windows XP → All
Hardware: PC → All

Updated

10 years ago
Attachment #287584 - Flags: review?(dcamp) → review+

Updated

10 years ago
Attachment #287598 - Flags: review+
(Assignee)

Comment 9

10 years ago
Comment on attachment 287584 [details] [diff] [review]
os x patch

Minor UI fix.  Actually seeking approval for both patches, but I'm too lazy to concatenate them.
Attachment #287584 - Flags: approval1.9?

Updated

10 years ago
Attachment #287584 - Flags: approval1.9? → approval1.9+
(Assignee)

Comment 10

10 years ago
Checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Flags: in-litmus?
This still doesn't really work, which is a major problem for Breakpad localizability.

http://bugs.aviary.pl/attachment.cgi?id=935

(the button should read "Uruchom ponownie program Firefox", but you can only see just a part of it; the same thing happens with the "Wyślij zgłoszenie"/"Send report" button)

The screenshot comes from Windows, but on Mac it's even worse...
(Assignee)

Comment 12

10 years ago
Marek:  This worked in my testing, but I was using English strings:
http://people.mozilla.com/~tmielczarek/crashreporter-long-strings.png

Is that Polish localization checked into CVS?  It may be a problem with the way we determine the length of non-ASCII strings.
Yes, pl is in CVS. http://lxr.mozilla.org/l10n/source/pl/toolkit/crashreporter/crashreporter.ini
(Assignee)

Comment 14

10 years ago
This WFM:
http://people.mozilla.com/~tmielczarek/crashreporter-pl.png
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2007121705 Minefield/3.0b3pre

Are you using an older version?  This may have landed after beta 1, I forget exactly when I checked it in.  I tried it in Vista as well and it works just the same.
I'm not sure what version the reporter of that bug (http://bugs.aviary.pl/show_bug.cgi?id=1391) was using. 

I've seen this broken on the Mac in b1 and in a release candidate of beta 2 on the Mac and a few builds in the interim.

I will try to reproduce this it later today with another trunk build.


(Assignee)

Comment 16

10 years ago
Ok, this does look terrible on Mac.  I'm going to be doing some more rework in bug 404855, so I'll make sure that gets fixed right in the process.
You need to log in before you can comment on or make changes to this bug.