Closed
Bug 393566
Opened 18 years ago
Closed 18 years ago
Add cycle collection to XULPopupListener
Categories
(Core :: XUL, defect)
Core
XUL
Tracking
()
RESOLVED
FIXED
People
(Reporter: enndeakin, Assigned: enndeakin)
References
Details
Attachments
(1 file)
|
3.75 KB,
patch
|
peterv
:
review+
peterv
:
superreview+
dbaron
:
approval1.9+
|
Details | Diff | Splinter Review |
|
||
Comment 1•18 years ago
|
||
The point being that right now we can leak, with the changes from bug
Blocks: 279703
Flags: blocking1.9?
|
Assignee | |
Comment 2•18 years ago
|
||
Assignee: nobody → enndeakin
Status: NEW → ASSIGNED
Attachment #278815 -
Flags: superreview?(peterv)
Attachment #278815 -
Flags: review?(peterv)
|
||
Comment 3•18 years ago
|
||
Comment on attachment 278815 [details] [diff] [review]
add cycle collection to nsXULPopupListener
>Index: content/xul/content/src/nsXULPopupListener.cpp
>===================================================================
> NS_INTERFACE_MAP_BEGIN(nsXULPopupListener)
> NS_INTERFACE_MAP_ENTRY(nsIDOMMouseListener)
> NS_INTERFACE_MAP_ENTRY(nsIDOMContextMenuListener)
> NS_INTERFACE_MAP_ENTRY_AMBIGUOUS(nsIDOMEventListener, nsIDOMMouseListener)
>+ NS_INTERFACE_MAP_ENTRIES_CYCLE_COLLECTION(nsXULPopupListener)
You could also replace NS_INTERFACE_MAP_BEGIN with NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION.
Attachment #278815 -
Flags: superreview?(peterv)
Attachment #278815 -
Flags: superreview+
Attachment #278815 -
Flags: review?(peterv)
Attachment #278815 -
Flags: review+
|
|
Assignee | |
Updated•18 years ago
|
Attachment #278815 -
Flags: approval1.9?
Comment on attachment 278815 [details] [diff] [review]
add cycle collection to nsXULPopupListener
a1.9=dbaron
Attachment #278815 -
Flags: approval1.9? → approval1.9+
|
|
Assignee | |
Updated•18 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
||
Updated•18 years ago
|
OS: Mac OS X → All
Hardware: PC → All
Component: XP Toolkit/Widgets: Menus → XUL
QA Contact: xptoolkit.menus → xptoolkit.widgets
You need to log in
before you can comment on or make changes to this bug.
Description
•