Closed
Bug 393569
Opened 17 years ago
Closed 17 years ago
don't show inactive stars in the location bar autocomplete results for non-bookmarked results, as the star is not interactive
Categories
(Firefox :: Address Bar, defect)
Firefox
Address Bar
Tracking
()
VERIFIED
FIXED
Firefox 3 alpha8
People
(Reporter: moco, Assigned: moco)
References
Details
Attachments
(1 file)
1.93 KB,
patch
|
dietrich
:
review+
|
Details | Diff | Splinter Review |
should clicking on the star in url bar autocomplete results drop down act like it does in the url bar?
note, the stars in the url bar autocomplete results haven't landed yet, see bug #387718
but it will look something like https://bugzilla.mozilla.org/attachment.cgi?id=277865
Comment 1•17 years ago
|
||
I don't think adding this many additional interactive elements to the autocomplete dropdown is a good idea. It could interfere with you trying to select an item. I also think it's unlikely that users are going to want to star things that are already in the dropdown; seems to me that they would generally star it on a first visit, or when they're otherwise already looking at the page.
Comment 2•17 years ago
|
||
Yeah, I agree with Gavin. We might want to use slightly faded starred and un-starred icons to help indicate that these elements are not interactive.
Assignee | ||
Comment 3•17 years ago
|
||
alex / gavin: thanks for commenting. if you think we should use slightly fadded icons (comment #2), let's morph this bug into that. otherwise, let's mark this as wontfix.
Comment 4•17 years ago
|
||
It should be made more obvious that they're not interactive. With current graphics I tried to bookmark a page from the dropdown and was surprised it didn't work.
Comment 5•17 years ago
|
||
>It should be made more obvious that they're not interactive. With current
>graphics I tried to bookmark a page from the dropdown and was surprised it
>didn't work.
yep, I agree. Let's morph this bug into using faded star icons.
Summary: should clicking on the star in url bar autocomplete results drop down act like it does in the url bar? → stars in the location bar autocomplete should be faded to indicate that they are not interactive
Comment 6•17 years ago
|
||
I'll post some temporary icons over in bug #392682 tomorrow and link to them here.
Comment 7•17 years ago
|
||
After talking with Seth, we've decided to only show stars, and not to show inactive stars, similar to the mockup in bug #393508
Assignee | ||
Comment 8•17 years ago
|
||
taking, this should be a simple quick fix. thank to faaborg for the ui guidance here.
Assignee: nobody → sspitzer
Flags: in-litmus?
Flags: blocking-firefox3?
Summary: stars in the location bar autocomplete should be faded to indicate that they are not interactive → don't show inactive starts in the location bar autocomplete results for non-bookmarked results, as the start is not interactive
Target Milestone: --- → Firefox 3 M8
Assignee | ||
Updated•17 years ago
|
Status: NEW → ASSIGNED
Summary: don't show inactive starts in the location bar autocomplete results for non-bookmarked results, as the start is not interactive → don't show inactive stars in the location bar autocomplete results for non-bookmarked results, as the star is not interactive
Assignee | ||
Comment 9•17 years ago
|
||
just remove the rules that show the "unstar" for results that are not bookmarks.
Attachment #279689 -
Flags: review?(dietrich)
Updated•17 years ago
|
Attachment #279689 -
Flags: review?(dietrich) → review+
Assignee | ||
Comment 10•17 years ago
|
||
fixed.
this has ui-r=faaborg.
Checking in pinstripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/pinstripe/browser/browser.css,v <-- browser.cs
s
new revision: 1.73; previous revision: 1.72
done
Checking in winstripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/winstripe/browser/browser.css,v <-- browser.cs
s
new revision: 1.88; previous revision: 1.87
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Comment 11•17 years ago
|
||
Litmus Triage team: stephend, will you handle the test case?
(In reply to comment #11)
> Litmus Triage team: stephend, will you handle the test case?
Done; http://litmus.mozilla.org/show_test.cgi?id=4679
in-litmus+ (let me know if it needs finessing)
Flags: in-litmus? → in-litmus+
Verified FIXED using:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007091204
Minefield/3.0a8pre
and Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a8pre)
Gecko/2007091204 Minefield/3.0a8pre
Status: RESOLVED → VERIFIED
Updated•17 years ago
|
Flags: blocking-firefox3? → blocking-firefox3+
You need to log in
before you can comment on or make changes to this bug.
Description
•