393609 - Cocoa drag-drop fails to put link text (urld) on pasteboard

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Since the Cocoa drag-drop rewrite, the text of a link (<a href="link_url">text of a link</a>) is no longer included on the clipboard.  (There are actually a vast number of flavors we no longer put on the clipboard--see attachment 278006 [details] in bug 363577--but we may not really want to restore all of them.)  This absence breaks at least drags->bookmarks in Camino (bug 363577).

(See also bug 380582 about including a Unicode variant of urld on the clipboard as well as urld.)

Comment 1

[Colin Barrett [:cbarrett]]

Not sure, but bug 386790 might fix this? Do you actually need the string "<a hrefblahblahblah" on the clipboard, or are you looking at the NSURLPboardType (you'd get an NSURL off it)?

Comment 2

[Stuart Morgan]

(In reply to comment #0)
> (See also bug 380582 about including a Unicode variant of urld on the clipboard
> as well as urld.)

One point that's relevant here is that, absent a good argument against it, I'd like to see urld as UTF-8 (which removes the need for bug 380582). See comments 5 and 8 of bug 296064; I'm don't see the expectation argument as compelling given that the whole problem is that under the old system clients have *absolutely* no idea what encoding the string is in.

> Do you actually need the string "<a hrefblahblahblah" on the clipboard,
> or are you looking at the NSURLPboardType (you'd get an NSURL off it)?

The title information isn't determinable from the URL. It's not the href part that matters, it's the "text of a link" part. E.g., if you grab the link "resolution" below and drag it, the work "resolution" needs to be avaialable in addition to "https://bugzilla.mozilla.org/page.cgi?id=fields.html#resolution"

Comment 3

[Stan Shebs]

I have a patch for 386790, but I got it partly by cribbing from Camino code. On the other hand, it's adding handling for the x-moz-url flavor to generic Cocoa drag handling, so maybe it will catch some of these cases too.

Comment 4

[Colin Barrett [:cbarrett]]

I wonder what Safari does in this case -- copy/pasting text with multiple URLs in it works fine to paste into Adium -- I'm guessing they're using NSHTMLPboardType and letting NSTextView do the heavy lifting of parsing that, but it would be interesting to test out

Comment 5

[Stan Shebs]

The text of a link seems to be handled as if it were a title, in other words the transferable contains "url\ntext" if you drag a link on a page, and "url\npagetitle" if you drag from the url bar. Not clear if this bit of ambiguity is a feature or not, there seems not be a flavor that can include two textual elements in addition to url. Anyway, Camino's bookmark dragging is fixed by taking the post-newline piece and adding it to the pasteboard twice, once as 'urln' and once as 'urld'. The patch is very simple, but depends on 386790's fix.

Comment 6

[Stan Shebs]

Attachment: add urld data to pasteboard

Comment 7

[Stuart Morgan]

(This will obviously need a different constant name as well, per bug 386790 comment 12)

Comment 8

[Stan Shebs]

Attachment: urld to pasteboard, with renamed constant

As before, with constant renamed for Camino compatibility.

Comment 10

[Josh Aas]

landed on trunk