393620 - Change SeaMonkey Vendor ID to "Mozilla"

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Peter Weilbacher]

Attachment: add preprocessing vendor ID

As discussed a while ago in mozilla.dev.apps.seamonkey the people supporting SeaMonkey on OS/2 (I CC'd some of them) agree that it would be a good idea to use "Mozilla" instead of "mozilla.org" as the Vendor ID for SeaMonkey.

The reasons that I can think of:
- People are used to having the SeaMonkey profile under
  %MOZILLA_HOME%\Mozilla.
- We think it will cause problems for our users and increase the need
  for support.
- Make it consistent with Firefox and Sunbird.
- It is annoying to us. ;-)
- We have had hardly any nightly builds since suiterunner was made the
  default so now is still time to make the change (back).
- The profile location on OS/2 is sufficiently different from other
  platforms anyway, so it should not cause extra support problems there.

The attached patch seems to do it.

Comment 1

[Robert Kaiser]

I think this whole bug is WONTFIX or even INVALID, actually, because the arguments in discussions leading to bug 335268 comment #5 haven't changed.
I'm not giving r- and closing this bug just yet, because I know how tenacious you people are.
There is no reason for treating OS/2 any differently than other platforms in this regard though, and I'm pretty sure we still just can't set our official vendor to be "Mozilla". We'd need to run this by Mozilla officials and I don't think I (or anyone else) can review this without an official word of those.
If anything, we could leave the vendor completely blank but I'm no fan of that either.

Comment 2

[Robert Kaiser]

Also see bug 330053 comment #48 and following for why we are using "mozilla.org" there.

Comment 3

[Peter Weilbacher]

(In reply to comment #1)
> If anything, we could leave the vendor completely blank but I'm no fan of that
> either.

And it wouldn't help the problem we have. The profile location would still be in a wrong location and only that I care about.

If the officials say that we cannot do this, then I am happy with that.

[If the answer is no then we should perhaps go on to think about a patch that for OS/2 just forces the profile location to be in %MOZILLA_HOME%\Mozilla\<AppName> without regard for the vendor ID. And/or to invent application specific environment variables <APPNAME>_HOME that would override MOZILLA_HOME, but I haven't thought about that in detail. I am sure both approaches would bring other problems.]

Comment 4

[[e-mail]]

Comment on attachment 278127 [details] [diff] [review]
add preprocessing vendor ID

Getting this off my radar, feel free to rerequest should you get official Mozilla sanction.

Comment 5

[Robert Kaiser]

I'm hijacking this bug to make it non-OS/2-specific.

Actually, the world has changed since we started off all this work on SeaMonkey 2 and MoFo seems to think that using "Mozilla" as vendor ID is actually OK for us as long as "Mozilla" is not appearing in our name in the UI (on |seamonkey --version| on the commandline it might be OK).

CCing Gerv for an official statement of MoFo. I also need to run this by the SeaMonkey Council before we can give green light on doing this.

Comment 6

[Gervase Markham [:gerv]]

I can confirm that, having discussed it with Frank, we have no objections to you using "Mozilla" as the vendor ID, thereby having parallel profile directories with Firefox, Thunderbird and Sunbird. 

The UI question is a different can of worms, not addressed by this bug. KaiRo tells me you don't want to do that anyway.

Gerv

Comment 7

[Robert Kaiser]

OK, the SeaMonkey Council has voted for this change, I'm only waiting on the outcome of the newsgroup discussion we have on how to deal with pre-alpha nightly testers needing to change their profile location.

Comment 8

[Robert Kaiser]

Attachment: patch: change vendor to "Mozilla"

Here's the patch - easy and nice.

I just moved the seamonkey/ subdir from ~/.mozilla.org to ~/.mozilla and the 2 profiles (a pretty default one and my day-to-day use one) continue to work fine from that new location, so the switchover seems to be easy and nice as well.

Comment 9

[Robert Kaiser]

Checked in, along with the tinder-config.pl updates for this, I'll post to newsgroups etc. once I know we'll stay green with it.

Comment 10

[Robert Kaiser]

Looks like tinderboxen reacted well to the change. Fixed.

Comment 11

[Worcester12345]

How come this bug was fixed, but the one for Thunderbird was not then?

Bug 247973 – Profiles should be stored under "Mozilla/Thunderbird" not "Thunderbird"

Comment 12

[Robert Kaiser]

Worcester12345: The SeaMonkey version of this and the Thunderbird one have nothing to do with each other, they are completely different application-specific issues.

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1]]

But how do you have solved the profile location change? Do you offer a migration service to the new location or what happens for users already using SeaMonkey?

Comment 14

[Robert Kaiser]

There is no automatic migration or whatever for this special case as it only affect nightly testers and not normal users. There is a wiki page explaining this, see http://wiki.mozilla.org/SeaMonkey:Moving_Profiles_from_mozilla.org_to_Mozilla and my blog entry at http://home.kairo.at/blog/2007-09/seamonkey_2_0a1pre_trunk_nightlies_switc should also make this a bit clearer.

Just to make this clear, this is a nice migration for users that come from SeaMonkey 1.x, but profiles have to be moved manually for nightly testers going from mozilla.org to Mozilla locations because of this bug report here.

Comment 15

[Boris Zbarsky [:bzbarsky]]

So after this change I can no longer start Seamonkey.  I just get a blank profile manager window.

I have:

% ls -l .mozilla/seamonkey
lrwxrwxrwx  1 bzbarsky winusers 25 Oct  4 01:06 .mozilla/seamonkey -> ../.mozilla.org/seamonkey

so I would have thought this would continue working transparently, no?

Comment 16

[Boris Zbarsky [:bzbarsky]]

Er, nevermind.  I was looking in the wrong homedir, and the right one had an apparently-busted "seamonkey" in .mozilla.