393623 - two small litmus.js bugs

Status: RESOLVED FIXED

(Other Applications Graveyard :: QA Companion, defect)

Description

[Ben Hsieh]

In litmus.js, Sysconfig.prototype = { platorm : null}

hooray for on-the-fly field creations! I wonder if this explains our spotty platForm detection.

The fix should be obvious, no patch attached.

Comment 1

[Ben Hsieh]

Attachment: two fixes

Comment 2

[Ben Hsieh]

(I figured that since there were two things that needed fixin' I might as well make the patch)

Comment 3

[Zach Lipton [:zach]]

Comment on attachment 278134 [details] [diff] [review]
two fixes

Ouch. Had we been using js warnings, we probably would have caught my stupid 'platorm' typo.

Comment 4

[Ben Hsieh]

reed, this is probably the most boring bug filed today.

Comment 5

[Reed Loden [:reed]]

Do you need help checking this in?

Comment 6

[Ben Hsieh]

Oh, interesting question. I think zach's been checking things in so far, but I'd think that either way is fine.

On the other hand, if you could check in https://bugzilla.mozilla.org/show_bug.cgi?id=390556   =] =] =]

Comment 7

[Reed Loden [:reed]]

(In reply to comment #6)
> Oh, interesting question. I think zach's been checking things in so far, but
> I'd think that either way is fine.

Ok, I can do it for you.

> On the other hand, if you could check in
> https://bugzilla.mozilla.org/show_bug.cgi?id=390556   =] =] =]

Once it has r+ from timeless, sure.

Comment 8

[Reed Loden [:reed]]

Checking in litmus.js;
/cvsroot/mozilla/testing/extensions/community/chrome/content/litmus.js,v  <--  litmus.js
new revision: 1.16; previous revision: 1.15
done