Closed Bug 393650 Opened 17 years ago Closed 17 years ago

XPCOMUtilify ExtensionManager

Categories

(Toolkit :: Add-ons Manager, defect)

Product:
Toolkit
Component:
Add-ons Manager
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9alpha8

People

(Reporter: rflint, Assigned: rflint)

References

Details

Attachments

(1 file, 1 obsolete file)

Patch v2
105.11 KB, patch
mossop
: review+
Details | Diff | Splinter Review
Attached patch Patch (obsolete) — — Splinter Review 
This patch makes the EM use XPCOMUtils and switches to Cc/Ci for ~6KB size win.
Attachment #278163 - Flags: review?(robert.bugzilla)
Please, for the love of whatever's holy, keep an eye on bug 299716 - you'll bitrot me again with this change, and I just got r=Mossop.  Barring something really bizarre, toolkit@mozilla.org will land really soon, and I'd ask you to hold this patch for that.

This bug is cosmetic; the other is not.
Depends on: toolkit@mozilla.org
Ryan, just wanted to let you know that I am waiting on at least bug 378216 to land before this.
Comment on attachment 278163 [details] [diff] [review]
Patch

Dave, can I get you to review this and make sure this gets in for M8? Thanks!
Attachment #278163 - Flags: review?(robert.bugzilla) → review?(dtownsend)
This is quite badly bit-rotted already and I'm planning to check in bug 378216 as soon as the tree is open. If we can get an updated patch then then I'll get right on it.
Depends on: 378216
Attached patch Patch v2 — — Splinter Review 

        Attachment #278163 -
        Attachment is obsolete: true

        Attachment #279536 -
        Flags: review?(dtownsend)

        Attachment #278163 -
        Flags: review?(dtownsend)

    
    

    
  
Comment on attachment 279536 [details] [diff] [review]
Patch v2

r=me. Lets get this landed a.s.a.p.

From going through this I think we could get some readability wins, if not other wins from some other improvements, caching the IO service for instance, using Components.constructor for some of the commonly used components.

        Attachment #279536 -
        Flags: review?(dtownsend) → review+

    
    

    
  
mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in 1.248
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 M8
Product: Firefox → Toolkit

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: